New Defects reported by Coverity Scan for NetBSD-i386-kernel

[scan-admin%coverity.com@localhost]

Hi,

Please find the latest report on new defect(s) introduced to NetBSD-i386-kernel found with Coverity Scan.

3 new defect(s) introduced to NetBSD-i386-kernel found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1297228:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
/sys/arch/x86/x86/intr.c: 563 in intr_allocate_io_intrsource()


________________________________________________________________________________________________________
*** CID 1297228:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
/sys/arch/x86/x86/intr.c: 563 in intr_allocate_io_intrsource()
557     	}
558     	isp->is_saved_evcnt = pep;
559     	for (CPU_INFO_FOREACH(cii, ci)) {
560     		pep->cpuid = ci->ci_cpuid;
561     		pep++;
562     	}
>>>     CID 1297228:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
>>>     Calling strncpy with a maximum size argument of 64 bytes on destination array "isp->is_intrid" of size 64 bytes might leave the destination string unterminated.
563     	strncpy(isp->is_intrid, intrid, sizeof(isp->is_intrid));
564     
565     	SIMPLEQ_INSERT_TAIL(&io_interrupt_sources, isp, is_list);
566     
567     	return isp;
568     }

** CID 1297229:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
/sys/dev/dksubr.c: 85 in dk_init()


________________________________________________________________________________________________________
*** CID 1297229:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
/sys/dev/dksubr.c: 85 in dk_init()
79     {
80     
81     	memset(dksc, 0x0, sizeof(*dksc));
82     	dksc->sc_dtype = dtype;
83     	dksc->sc_dev = dev;
84     
>>>     CID 1297229:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
>>>     Calling strncpy with a maximum size argument of 8 bytes on destination array "dksc->sc_xname" of size 8 bytes might leave the destination string unterminated.
85     	strncpy(dksc->sc_xname, device_xname(dev), DK_XNAME_SIZE);
86     	dksc->sc_dkdev.dk_name = dksc->sc_xname;
87     }
88     
89     void
90     dk_attach(struct dk_softc *dksc)

** CID 1297230:  Control flow issues  (DEADCODE)
/sys/dev/pci/ixgbe/ixgbe.c: 1980 in ixgbe_xmit()


________________________________________________________________________________________________________
*** CID 1297230:  Control flow issues  (DEADCODE)
/sys/dev/pci/ixgbe/ixgbe.c: 1980 in ixgbe_xmit()
1974     		case EINVAL:
1975     			adapter->einval_tx_dma_setup.ev_count++;
1976     			return error;
1977     		default:
1978     			adapter->other_tx_dma_setup.ev_count++;
1979     			return error;
>>>     CID 1297230:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement "case 0:".
1980     		case 0:
1981     			break;
1982     		}
1983     	}
1984     
1985     	/* Make certain there are enough descriptors */


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/1450?tab=overview

To manage Coverity Scan email notifications for "coverity-updates%netbsd.org@localhost", click https://scan.coverity.com/subscriptions/edit?email=coverity-updates%40netbsd.org&token=487286ca1a9a4f4bd485d16f66b5e782 .