New Defects reported by Coverity Scan for NetBSD-amd64-user

[scan-admin%coverity.com@localhost]

Hi,

Please find the latest report on new defect(s) introduced to NetBSD-amd64-user found with Coverity Scan.

4 new defect(s) introduced to NetBSD-amd64-user found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1323914:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4080 in DeIconify()


________________________________________________________________________________________________________
*** CID 1323914:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4080 in DeIconify()
4074         TwmWindow *t = tmp_win;
4075         int isicon = FALSE;
4076     
4077         /* de-iconify the main window */
4078         if (Scr->WindowMask)
4079     	XRaiseWindow (dpy, Scr->WindowMask);
>>>     CID 1323914:  Null pointer dereferences  (FORWARD_NULL)
>>>     Comparing "tmp_win" to null implies that "tmp_win" might be null.
4080         if (tmp_win && tmp_win->isicon)
4081         {
4082     	isicon = TRUE;
4083     	if (tmp_win->icon_on && tmp_win->icon && tmp_win->icon->w)
4084     	    Zoom(tmp_win->icon->w, tmp_win->frame);
4085     	else if (tmp_win->group != (Window) 0)

** CID 1323915:  Uninitialized variables  (UNINIT)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2656 in WMgrHandleButtonEvent()


________________________________________________________________________________________________________
*** CID 1323915:  Uninitialized variables  (UNINIT)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2656 in WMgrHandleButtonEvent()
2650     {
2651         WorkSpaceWindow	*mw;
2652         WorkSpace		*ws, *oldws, *newws, *cws;
2653         WinList		wl;
2654         TwmWindow		*win;
2655         int			occupation;
>>>     CID 1323915:  Uninitialized variables  (UNINIT)
>>>     Declaring variable "H0" without initializer.
2656         unsigned int	W0, H0, bw;
2657         int			cont;
2658         XEvent		ev;
2659         Window		w, sw, parent;
2660         int			X0, Y0, X1, Y1, XW, YW, XSW, YSW;
2661         Position		newX = 0, newY = 0, winX = 0, winY = 0;

** CID 1323916:  Uninitialized variables  (UNINIT)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2656 in WMgrHandleButtonEvent()


________________________________________________________________________________________________________
*** CID 1323916:  Uninitialized variables  (UNINIT)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2656 in WMgrHandleButtonEvent()
2650     {
2651         WorkSpaceWindow	*mw;
2652         WorkSpace		*ws, *oldws, *newws, *cws;
2653         WinList		wl;
2654         TwmWindow		*win;
2655         int			occupation;
>>>     CID 1323916:  Uninitialized variables  (UNINIT)
>>>     Declaring variable "W0" without initializer.
2656         unsigned int	W0, H0, bw;
2657         int			cont;
2658         XEvent		ev;
2659         Window		w, sw, parent;
2660         int			X0, Y0, X1, Y1, XW, YW, XSW, YSW;
2661         Position		newX = 0, newY = 0, winX = 0, winY = 0;

** CID 1323917:    (UNINIT)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2876 in WMgrHandleButtonEvent()
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2659 in WMgrHandleButtonEvent()


________________________________________________________________________________________________________
*** CID 1323917:    (UNINIT)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2876 in WMgrHandleButtonEvent()
2870     				win->title_height + win->frame_bw3D);
2871     		    }
2872     		}
2873     move:		XMoveWindow (dpy, w, newX - XW, newY - YW);
2874     		break;
2875     	    case Expose :
>>>     CID 1323917:    (UNINIT)
>>>     Using uninitialized value "w".
2876     		if (ev.xexpose.window == w) {
2877     		    WMapRedrawWindow (w, W0, H0, wl->cp, wl->twm_win->icon_name);
2878     		    break;
2879     		}
2880     		Event = ev;
2881     		DispatchEvent ();
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2659 in WMgrHandleButtonEvent()
2653         WinList		wl;
2654         TwmWindow		*win;
2655         int			occupation;
2656         unsigned int	W0, H0, bw;
2657         int			cont;
2658         XEvent		ev;
>>>     CID 1323917:    (UNINIT)
>>>     Declaring variable "w" without initializer.
2659         Window		w, sw, parent;
2660         int			X0, Y0, X1, Y1, XW, YW, XSW, YSW;
2661         Position		newX = 0, newY = 0, winX = 0, winY = 0;
2662         Window		junkW;
2663         unsigned int	junk;
2664         unsigned int	button;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/netbsd-amd64-user?tab=overview

To manage Coverity Scan email notifications for "coverity-updates%netbsd.org@localhost", click https://scan.coverity.com/subscriptions/edit?email=coverity-updates%40netbsd.org&token=487286ca1a9a4f4bd485d16f66b5e782