New Defects reported by Coverity Scan for NetBSD-amd64-kernel

[scan-admin%coverity.com@localhost]

Hi,

Please find the latest report on new defect(s) introduced to NetBSD-amd64-kernel found with Coverity Scan.

2 new defect(s) introduced to NetBSD-amd64-kernel found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1328432:  Security best practices violations  (DC.WEAK_CRYPTO)
/sys/dev/pci/if_wm.c: 4086 in wm_init_rss()


________________________________________________________________________________________________________
*** CID 1328432:  Security best practices violations  (DC.WEAK_CRYPTO)
/sys/dev/pci/if_wm.c: 4086 in wm_init_rss()
4080     		reta_reg &= ~RETA_ENTRY_MASK_Q(i);
4081     		reta_reg |= __SHIFTIN(reta_ent, RETA_ENTRY_MASK_Q(i));
4082     		CSR_WRITE(sc, WMREG_RETA_Q(i), reta_reg);
4083     	}
4084     
4085     	for (i = 0; i < RSSRK_NUM_REGS; i++)
>>>     CID 1328432:  Security best practices violations  (DC.WEAK_CRYPTO)
>>>     "random" should not be used for security related applications, as linear congruential algorithms are too easy to break.
4086     		CSR_WRITE(sc, WMREG_RSSRK(i), (uint32_t)random());
4087     
4088     	if (sc->sc_type == WM_T_82574)
4089     		mrqc = MRQC_ENABLE_RSS_MQ_82574;
4090     	else
4091     		mrqc = MRQC_ENABLE_RSS_MQ;

** CID 1328433:  Control flow issues  (DEADCODE)
/sys/dev/pci/agp_i810.c: 449 in agp_i810_attach()


________________________________________________________________________________________________________
*** CID 1328433:  Control flow issues  (DEADCODE)
/sys/dev/pci/agp_i810.c: 449 in agp_i810_attach()
443     	 * not a priori clear to me there is any other reason to
444     	 * require this.
445     	 */
446     	mmadr_type = pci_mapreg_type(isc->vga_pa.pa_pc, isc->vga_pa.pa_tag,
447     	    mmadr_bar);
448     	if ((mmadr_type & PCI_MAPREG_TYPE_MEM) != PCI_MAPREG_TYPE_MEM) {
>>>     CID 1328433:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "aprint_error_dev(self, "non...".
449     		aprint_error_dev(self, "non-memory device MMIO registers\n");
450     		error = ENXIO;
451     		goto fail1;
452     	}
453     
454     	/*


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/netbsd-amd64-kernel?tab=overview

To manage Coverity Scan email notifications for "coverity-updates%netbsd.org@localhost", click https://scan.coverity.com/subscriptions/edit?email=coverity-updates%40netbsd.org&token=487286ca1a9a4f4bd485d16f66b5e782