Coverity-updates archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
New Defects reported by Coverity Scan for NetBSD-amd64-kernel
Hi,
Please find the latest report on new defect(s) introduced to NetBSD-amd64-kernel found with Coverity Scan.
447 new defect(s) introduced to NetBSD-amd64-kernel found with Coverity Scan.
43 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 447 defect(s)
** CID 1427783: Null pointer dereferences (REVERSE_INULL)
/sys/dev/usb/if_bwfm_usb.c: 727 in bwfm_usb_load_microcode()
________________________________________________________________________________________________________
*** CID 1427783: Null pointer dereferences (REVERSE_INULL)
/sys/dev/usb/if_bwfm_usb.c: 727 in bwfm_usb_load_microcode()
721 bwfm_usb_dl_cmd(sc, DL_GO, &state, sizeof(state));
722
723 usbd_destroy_xfer(xfer);
724
725 return 0;
726 err:
>>> CID 1427783: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "sc->sc_tx_pipeh" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
727 if (sc->sc_tx_pipeh != NULL) {
728 usbd_abort_pipe(sc->sc_tx_pipeh);
729 usbd_close_pipe(sc->sc_tx_pipeh);
730 sc->sc_tx_pipeh = NULL;
731 }
732 if (xfer != NULL)
** CID 1427782: Null pointer dereferences (REVERSE_INULL)
/sys/netipsec/ipsec.c: 1450 in ipsec4_set_policy()
________________________________________________________________________________________________________
*** CID 1427782: Null pointer dereferences (REVERSE_INULL)
/sys/netipsec/ipsec.c: 1450 in ipsec4_set_policy()
1444 struct secpolicy **policy;
1445
1446 KASSERT(!cpu_softintr_p());
1447 KASSERT(inp_locked(inp));
1448
1449 /* sanity check. */
>>> CID 1427782: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "inp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1450 if (inp == NULL || request == NULL)
1451 return EINVAL;
1452 if (len < sizeof(*xpl))
1453 return EINVAL;
1454 xpl = (const struct sadb_x_policy *)request;
1455
** CID 1427781: Null pointer dereferences (FORWARD_NULL)
/sys/dev/usb/umidi.c: 815 in alloc_all_endpoints_fixed_ep()
________________________________________________________________________________________________________
*** CID 1427781: Null pointer dereferences (FORWARD_NULL)
/sys/dev/usb/umidi.c: 815 in alloc_all_endpoints_fixed_ep()
809 ep->addr = epd->bEndpointAddress;
810 ep->num_jacks = fp->out_ep[i].num_jacks;
811 sc->sc_out_num_jacks += fp->out_ep[i].num_jacks;
812 ep->num_open = 0;
813 ep++;
814 }
>>> CID 1427781: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "sc->sc_in_ep".
815 ep = &sc->sc_in_ep[0];
816 for (i = 0; i < sc->sc_in_num_endpoints; i++) {
817 epd = usbd_interface2endpoint_descriptor(
818 sc->sc_iface,
819 fp->in_ep[i].ep);
820 if (!epd) {
** CID 1427780: Null pointer dereferences (REVERSE_INULL)
/sys/external/bsd/ipf/netinet/ip_fil_netbsd.c: 1436 in ipf_fastroute6()
________________________________________________________________________________________________________
*** CID 1427780: Null pointer dereferences (REVERSE_INULL)
/sys/external/bsd/ipf/netinet/ip_fil_netbsd.c: 1436 in ipf_fastroute6()
1430 return error;
1431
1432 dst = &u.dst;
1433 rtcache_setdst(ro, dst);
1434
1435 rt = rtcache_init(ro);
>>> CID 1427780: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "ifp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1436 if ((ifp == NULL) && (rt != NULL))
1437 ifp = rt->rt_ifp;
1438 # else
1439 dst6 = (struct sockaddr_in6 *)&ro->ro_dst;
1440 dst6->sin6_family = AF_INET6;
1441 dst6->sin6_len = sizeof(struct sockaddr_in6);
** CID 1427779: Uninitialized variables (UNINIT)
/sys/dev/pci/if_wm.c: 12592 in wm_nvm_version()
________________________________________________________________________________________________________
*** CID 1427779: Uninitialized variables (UNINIT)
/sys/dev/pci/if_wm.c: 12592 in wm_nvm_version()
12586 check_optionrom = true;
12587 have_build = true;
12588 break;
12589 case WM_T_82575:
12590 case WM_T_82576:
12591 case WM_T_82580:
>>> CID 1427779: Uninitialized variables (UNINIT)
>>> Using uninitialized value "uid1".
12592 if ((uid1 & NVM_MAJOR_MASK) != NVM_UID_VALID)
12593 check_version = true;
12594 break;
12595 case WM_T_I211:
12596 wm_nvm_version_invm(sc);
12597 have_uid = false;
** CID 1427778: (FORWARD_NULL)
/sys/uvm/uvm_page.c: 633 in uvm_page_physget_freelist()
/sys/uvm/uvm_page.c: 633 in uvm_page_physget_freelist()
/sys/uvm/uvm_page.c: 648 in uvm_page_physget_freelist()
________________________________________________________________________________________________________
*** CID 1427778: (FORWARD_NULL)
/sys/uvm/uvm_page.c: 633 in uvm_page_physget_freelist()
627 {
628 if (uvm.page_init_done == true)
629 panic("uvm_page_physget: called _after_ bootstrap");
630
631 /* Try to match at front or back on unused segment */
632 if (uvm_page_physunload(lcv, freelist, paddrp) == false) {
>>> CID 1427778: (FORWARD_NULL)
>>> Comparing "paddrp" to null implies that "paddrp" might be null.
633 if (paddrp == NULL) /* freelist fail, try next */
634 continue;
635 } else
636 return true;
637 }
638
/sys/uvm/uvm_page.c: 633 in uvm_page_physget_freelist()
627 {
628 if (uvm.page_init_done == true)
629 panic("uvm_page_physget: called _after_ bootstrap");
630
631 /* Try to match at front or back on unused segment */
632 if (uvm_page_physunload(lcv, freelist, paddrp) == false) {
>>> CID 1427778: (FORWARD_NULL)
>>> Comparing "paddrp" to null implies that "paddrp" might be null.
633 if (paddrp == NULL) /* freelist fail, try next */
634 continue;
635 } else
636 return true;
637 }
638
/sys/uvm/uvm_page.c: 648 in uvm_page_physget_freelist()
642 #else
643 for (lcv = uvm_physseg_get_first(); uvm_physseg_valid_p(lcv); lcv = uvm_physseg_get_next(lcv))
644 #endif
645 {
646 /* Try the front regardless. */
647 if (uvm_page_physunload_force(lcv, freelist, paddrp) == false) {
>>> CID 1427778: (FORWARD_NULL)
>>> Comparing "paddrp" to null implies that "paddrp" might be null.
648 if (paddrp == NULL) /* freelist fail, try next */
649 continue;
650 } else
651 return true;
652 }
653 return false;
** CID 1427777: Null pointer dereferences (REVERSE_INULL)
/sys/dev/usb/uvideo.c: 826 in uvideo_init_control()
________________________________________________________________________________________________________
*** CID 1427777: Null pointer dereferences (REVERSE_INULL)
/sys/dev/usb/uvideo.c: 826 in uvideo_init_control()
820 ++i;
821 }
822
823 return USBD_NORMAL_COMPLETION;
824
825 enomem:
>>> CID 1427777: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "sc->sc_unit" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
826 if (sc->sc_unit != NULL) {
827 for (j = 0; j < i; ++j) {
828 uvideo_unit_free(sc->sc_unit[j]);
829 sc->sc_unit[j] = NULL;
830 }
831 kmem_free(sc->sc_unit, sizeof(*sc->sc_unit) * nunits);
** CID 1427776: Null pointer dereferences (FORWARD_NULL)
/sys/dev/usb/umidi.c: 789 in alloc_all_endpoints_fixed_ep()
________________________________________________________________________________________________________
*** CID 1427776: Null pointer dereferences (FORWARD_NULL)
/sys/dev/usb/umidi.c: 789 in alloc_all_endpoints_fixed_ep()
783 sc->sc_endpoints = kmem_zalloc(sc->sc_endpoints_len, KM_SLEEP);
784 sc->sc_out_ep = sc->sc_out_num_endpoints ? sc->sc_endpoints : NULL;
785 sc->sc_in_ep =
786 sc->sc_in_num_endpoints ?
787 sc->sc_endpoints+sc->sc_out_num_endpoints : NULL;
788
>>> CID 1427776: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "sc->sc_out_ep".
789 ep = &sc->sc_out_ep[0];
790 for (i = 0; i < sc->sc_out_num_endpoints; i++) {
791 epd = usbd_interface2endpoint_descriptor(
792 sc->sc_iface,
793 fp->out_ep[i].ep);
794 if (!epd) {
** CID 1427775: Program hangs (LOCK)
/sys/external/bsd/drm2/dist/drm/nouveau/nouveau_nv50_display.c: 508 in evo_wait()
________________________________________________________________________________________________________
*** CID 1427775: Program hangs (LOCK)
/sys/external/bsd/drm2/dist/drm/nouveau/nouveau_nv50_display.c: 508 in evo_wait()
502 return NULL;
503 }
504
505 put = 0;
506 }
507
>>> CID 1427775: Program hangs (LOCK)
>>> Returning without unlocking "dmac->lock".
508 return dmac->ptr + put;
509 }
510
511 static void
512 evo_kick(u32 *push, void *evoc)
513 {
** CID 1427774: Memory - corruptions (OVERRUN)
________________________________________________________________________________________________________
*** CID 1427774: Memory - corruptions (OVERRUN)
/sys/external/bsd/drm2/dist/drm/i915/intel_i2c.c: 513 in gmbus_xfer()
507 reg_offset = dev_priv->gpio_mmio_base;
508
509 I915_WRITE(GMBUS0 + reg_offset, bus->reg0);
510
511 for (i = 0; i < num; i++) {
512 if (gmbus_is_index_read(msgs, i, num)) {
>>> CID 1427774: Memory - corruptions (OVERRUN)
>>> Overrunning struct type i2c_msg of 16 bytes by passing it to a function which accesses it at byte offset 16.
513 ret = gmbus_xfer_index_read(dev_priv, &msgs[i]);
514 i += 1; /* set i to the index of the read xfer */
515 } else if (msgs[i].flags & I2C_M_RD) {
516 ret = gmbus_xfer_read(dev_priv, &msgs[i], 0);
517 } else {
518 ret = gmbus_xfer_write(dev_priv, &msgs[i]);
** CID 1427773: Control flow issues (DEADCODE)
/sys/dev/pci/ixgbe/ixgbe.c: 4499 in ixgbe_enable_intr()
________________________________________________________________________________________________________
*** CID 1427773: Control flow issues (DEADCODE)
/sys/dev/pci/ixgbe/ixgbe.c: 4499 in ixgbe_enable_intr()
4493 if (adapter->msix_mem) {
4494 mask = IXGBE_EIMS_ENABLE_MASK;
4495 /* Don't autoclear Link */
4496 mask &= ~IXGBE_EIMS_OTHER;
4497 mask &= ~IXGBE_EIMS_LSC;
4498 if (adapter->feat_cap & IXGBE_FEATURE_SRIOV)
>>> CID 1427773: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "mask &= 0xfff7ffffU;".
4499 mask &= ~IXGBE_EIMS_MAILBOX;
4500 IXGBE_WRITE_REG(hw, IXGBE_EIAC, mask);
4501 }
4502
4503 /*
4504 * Now enable all queues, this is done separately to
** CID 1427772: Null pointer dereferences (FORWARD_NULL)
/sys/nfs/nfs_subs.c: 1367 in nfs_enterdircache()
________________________________________________________________________________________________________
*** CID 1427772: Null pointer dereferences (FORWARD_NULL)
/sys/nfs/nfs_subs.c: 1367 in nfs_enterdircache()
1361 goto done;
1362 nfs_unlinkdircache(np, ndp);
1363 nfs_putdircache_unlocked(np, ndp);
1364 ndp = NULL;
1365 }
1366
>>> CID 1427772: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "np->n_un1.nu_dir.ndir_dircache".
1367 ndhp = &np->n_dircache[hashent];
1368
1369 if (!ndp) {
1370 if (newndp == NULL) {
1371 NFSDC_UNLOCK(np);
1372 newndp = kmem_alloc(sizeof(*newndp), KM_SLEEP);
** CID 1427771: Memory - illegal accesses (OVERRUN)
/sys/dev/wsfb/genfb.c: 636 in genfb_putcmap()
________________________________________________________________________________________________________
*** CID 1427771: Memory - illegal accesses (OVERRUN)
/sys/dev/wsfb/genfb.c: 636 in genfb_putcmap()
630
631 r = &sc->sc_cmap_red[index];
632 g = &sc->sc_cmap_green[index];
633 b = &sc->sc_cmap_blue[index];
634
635 for (i = 0; i < count; i++) {
>>> CID 1427771: Memory - illegal accesses (OVERRUN)
>>> Overrunning array of 256 bytes at byte offset 510 by dereferencing pointer "b".
636 genfb_putpalreg(sc, index, *r, *g, *b);
637 index++;
638 r++, g++, b++;
639 }
640 return 0;
641 }
** CID 1427770: Null pointer dereferences (NULL_RETURNS)
/sys/netipsec/ipsec_input.c: 138 in ipsec4_fixup_checksum()
________________________________________________________________________________________________________
*** CID 1427770: Null pointer dereferences (NULL_RETURNS)
/sys/netipsec/ipsec_input.c: 138 in ipsec4_fixup_checksum()
132 struct udphdr *uh;
133 int poff, off;
134 int plen;
135
136 if (m->m_len < sizeof(*ip))
137 m = m_pullup(m, sizeof(*ip));
>>> CID 1427770: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a null pointer "m".
138 ip = mtod(m, struct ip *);
139 poff = ip->ip_hl << 2;
140 plen = ntohs(ip->ip_len) - poff;
141
142 switch (ip->ip_p) {
143 case IPPROTO_TCP:
** CID 1427769: Null pointer dereferences (FORWARD_NULL)
/sys/dev/raidframe/rf_stripelocks.c: 413 in rf_ReleaseStripeLock()
________________________________________________________________________________________________________
*** CID 1427769: Null pointer dereferences (FORWARD_NULL)
/sys/dev/raidframe/rf_stripelocks.c: 413 in rf_ReleaseStripeLock()
407 break;
408 }
409 RF_ASSERT(lockDesc); /* major error to release a lock that doesn't
410 * exist */
411
412 /* find the stripe lock request descriptor & delete it from the list */
>>> CID 1427769: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "lockDesc".
413 for (lr_t = NULL, lr = lockDesc->granted; lr; lr_t = lr, lr = lr->next)
414 if (lr == lockReqDesc)
415 break;
416
417 RF_ASSERT(lr && (lr == lockReqDesc)); /* major error to release a
418 * lock that hasn't been
** CID 1427768: Memory - illegal accesses (OVERRUN)
/sys/kern/subr_disk_mbr.c: 735 in setdisklabel()
________________________________________________________________________________________________________
*** CID 1427768: Memory - illegal accesses (OVERRUN)
/sys/kern/subr_disk_mbr.c: 735 in setdisklabel()
729 opp = &olp->d_partitions[i];
730 npp = &nlp->d_partitions[i];
731 /*
732 * Copy internally-set partition information
733 * if new label doesn't include it. XXX
734 */
>>> CID 1427768: Memory - illegal accesses (OVERRUN)
>>> Overrunning array of 16 16-byte elements at element index 16 (byte offset 256) by dereferencing pointer "npp".
735 if (npp->p_fstype == FS_UNUSED && opp->p_fstype != FS_UNUSED) {
736 *npp = *opp;
737 continue;
738 }
739 if (npp->p_offset != opp->p_offset || npp->p_size < opp->p_size)
740 return (EBUSY);
** CID 1427767: (TAINTED_SCALAR)
/sys/compat/netbsd32/netbsd32_socket.c: 286 in copyin32_msg_control()
/sys/compat/netbsd32/netbsd32_socket.c: 286 in copyin32_msg_control()
________________________________________________________________________________________________________
*** CID 1427767: (TAINTED_SCALAR)
/sys/compat/netbsd32/netbsd32_socket.c: 286 in copyin32_msg_control()
280 }
281 control = nc;
282 clen = nclen;
283 }
284
285 /* Copy header */
>>> CID 1427767: (TAINTED_SCALAR)
>>> Using tainted variable "cidx" as an index to pointer "control".
286 cmsg = (void *)&control[cidx];
287 cmsg->cmsg_len = CMSG_LEN(cmsg32.cmsg_len - CMSG32_LEN(0));
288 cmsg->cmsg_level = cmsg32.cmsg_level;
289 cmsg->cmsg_type = cmsg32.cmsg_type;
290
291 /* Copyin the data */
/sys/compat/netbsd32/netbsd32_socket.c: 286 in copyin32_msg_control()
280 }
281 control = nc;
282 clen = nclen;
283 }
284
285 /* Copy header */
>>> CID 1427767: (TAINTED_SCALAR)
>>> Using tainted variable "cidx" as an index to pointer "control".
286 cmsg = (void *)&control[cidx];
287 cmsg->cmsg_len = CMSG_LEN(cmsg32.cmsg_len - CMSG32_LEN(0));
288 cmsg->cmsg_level = cmsg32.cmsg_level;
289 cmsg->cmsg_type = cmsg32.cmsg_type;
290
291 /* Copyin the data */
** CID 1427766: Control flow issues (DEADCODE)
/sys/external/bsd/drm2/dist/drm/nouveau/core/subdev/gpio/nouveau_subdev_gpio_base.c: 65 in nouveau_gpio_find()
________________________________________________________________________________________________________
*** CID 1427766: Control flow issues (DEADCODE)
/sys/external/bsd/drm2/dist/drm/nouveau/core/subdev/gpio/nouveau_subdev_gpio_base.c: 65 in nouveau_gpio_find()
59 if (data)
60 return 0;
61
62 /* Apple iMac G4 NV18 */
63 if (nv_device_match(nv_object(gpio), 0x0189, 0x10de, 0x0010)) {
64 if (tag == DCB_GPIO_TVDAC0) {
>>> CID 1427766: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "<temporary>.log[<temporary>...".
65 *func = (struct dcb_gpio_func) {
66 .func = DCB_GPIO_TVDAC0,
67 .line = 4,
68 .log[0] = 0,
69 .log[1] = 1,
70 };
** CID 1427765: (DEADCODE)
/sys/dev/pci/ixgbe/ixv.c: 1588 in ixv_initialize_rss_mapping()
/sys/dev/pci/ixgbe/ixv.c: 1591 in ixv_initialize_rss_mapping()
/sys/dev/pci/ixgbe/ixv.c: 1594 in ixv_initialize_rss_mapping()
/sys/dev/pci/ixgbe/ixv.c: 1596 in ixv_initialize_rss_mapping()
/sys/dev/pci/ixgbe/ixv.c: 1598 in ixv_initialize_rss_mapping()
________________________________________________________________________________________________________
*** CID 1427765: (DEADCODE)
/sys/dev/pci/ixgbe/ixv.c: 1588 in ixv_initialize_rss_mapping()
1582 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV4_TCP;
1583 if (rss_hash_config & RSS_HASHTYPE_RSS_IPV6)
1584 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6;
1585 if (rss_hash_config & RSS_HASHTYPE_RSS_TCP_IPV6)
1586 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_TCP;
1587 if (rss_hash_config & RSS_HASHTYPE_RSS_IPV6_EX)
>>> CID 1427765: (DEADCODE)
>>> Execution cannot reach this statement: "device_printf(adapter->dev,...".
1588 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_IPV6_EX defined, but not supported\n",
1589 __func__);
1590 if (rss_hash_config & RSS_HASHTYPE_RSS_TCP_IPV6_EX)
1591 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_TCP_IPV6_EX defined, but not supported\n",
1592 __func__);
1593 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV4)
/sys/dev/pci/ixgbe/ixv.c: 1591 in ixv_initialize_rss_mapping()
1585 if (rss_hash_config & RSS_HASHTYPE_RSS_TCP_IPV6)
1586 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_TCP;
1587 if (rss_hash_config & RSS_HASHTYPE_RSS_IPV6_EX)
1588 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_IPV6_EX defined, but not supported\n",
1589 __func__);
1590 if (rss_hash_config & RSS_HASHTYPE_RSS_TCP_IPV6_EX)
>>> CID 1427765: (DEADCODE)
>>> Execution cannot reach this statement: "device_printf(adapter->dev,...".
1591 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_TCP_IPV6_EX defined, but not supported\n",
1592 __func__);
1593 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV4)
1594 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV4_UDP;
1595 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6)
1596 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_UDP;
/sys/dev/pci/ixgbe/ixv.c: 1594 in ixv_initialize_rss_mapping()
1588 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_IPV6_EX defined, but not supported\n",
1589 __func__);
1590 if (rss_hash_config & RSS_HASHTYPE_RSS_TCP_IPV6_EX)
1591 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_TCP_IPV6_EX defined, but not supported\n",
1592 __func__);
1593 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV4)
>>> CID 1427765: (DEADCODE)
>>> Execution cannot reach this statement: "mrqc |= 0x400000U;".
1594 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV4_UDP;
1595 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6)
1596 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_UDP;
1597 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6_EX)
1598 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_UDP_IPV6_EX defined, but not supported\n",
1599 __func__);
/sys/dev/pci/ixgbe/ixv.c: 1596 in ixv_initialize_rss_mapping()
1590 if (rss_hash_config & RSS_HASHTYPE_RSS_TCP_IPV6_EX)
1591 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_TCP_IPV6_EX defined, but not supported\n",
1592 __func__);
1593 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV4)
1594 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV4_UDP;
1595 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6)
>>> CID 1427765: (DEADCODE)
>>> Execution cannot reach this statement: "mrqc |= 0x800000U;".
1596 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_UDP;
1597 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6_EX)
1598 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_UDP_IPV6_EX defined, but not supported\n",
1599 __func__);
1600 IXGBE_WRITE_REG(hw, IXGBE_VFMRQC, mrqc);
1601 } /* ixv_initialize_rss_mapping */
/sys/dev/pci/ixgbe/ixv.c: 1598 in ixv_initialize_rss_mapping()
1592 __func__);
1593 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV4)
1594 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV4_UDP;
1595 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6)
1596 mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_UDP;
1597 if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6_EX)
>>> CID 1427765: (DEADCODE)
>>> Execution cannot reach this statement: "device_printf(adapter->dev,...".
1598 device_printf(adapter->dev, "%s: RSS_HASHTYPE_RSS_UDP_IPV6_EX defined, but not supported\n",
1599 __func__);
1600 IXGBE_WRITE_REG(hw, IXGBE_VFMRQC, mrqc);
1601 } /* ixv_initialize_rss_mapping */
1602
1603
** CID 1427764: Code maintainability issues (UNUSED_VALUE)
/sys/dev/ic/tulip.c: 4763 in tlp_2114x_isv_tmsw_init()
________________________________________________________________________________________________________
*** CID 1427764: Code maintainability issues (UNUSED_VALUE)
/sys/dev/ic/tulip.c: 4763 in tlp_2114x_isv_tmsw_init()
4757 tm->tm_gp_offset = cp - &sc->sc_srom[0];
4758 cp += tm->tm_gp_length;
4759
4760 /* Next is the MII reset sequence length and offset. */
4761 tm->tm_reset_length = *cp++;
4762 tm->tm_reset_offset = cp - &sc->sc_srom[0];
>>> CID 1427764: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value from "cp + tm->tm_reset_length" to "cp" here, but that stored value is overwritten before it can be used.
4763 cp += tm->tm_reset_length;
4764
4765 /*
4766 * The following items are left in the media block
4767 * that we don't particularly care about:
4768 *
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRb2JZfDAOAZcqzsy8LMBKBj0qtSICo2DZNjmmsVjYof54PahgUQ7xLRwU5wjlAON3Q-3D_XWm3CUIFU8ffmjzuNhQ8cIHoQgXzXkm61Fmjr59D05XZ3Mi28R3BLY4IewznbwIpJcLSiQhgr-2FoRlSVHaBJLTpHBYVYfD0UTfzE1X9DR1SkzHSfd-2BdTHXkc9XncHZRfafuKdiSA3tWnHIOKAMFi7RORJScx6aUXoE4Pau9Di4Cpj-2F-2BCvx5BI3bdXoOJesamkbRc2jEb7AVlbMYlsMTSjB94b9F2P3OBUUJGNzFPBinY-3D
To manage Coverity Scan email notifications for "coverity-updates%netbsd.org@localhost", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4m7U7Yoel-2F6MYPxol7ToiLwYIjoNbVQOCAwEeTNJofEDwTlN0JRhKMyijhpnAObR-2FlLVG-2Fr3EBKWgiICNdX1HPA6Ws0-2F1wHBf2tG9AnMDB8g-3D_XWm3CUIFU8ffmjzuNhQ8cIHoQgXzXkm61Fmjr59D05XZ3Mi28R3BLY4IewznbwIpJcLSiQhgr-2FoRlSVHaBJLTjCwlsGyliXHX5c5eU2CI-2BMUEOxRDICnmPMVxTQ1JLSWEs-2FjQahbJsaULB8nYA3zscP5ZIqSH1HYkxyg-2BLZA7mMEZKXaPb9nlUIjf3By344Ega69B6i5O-2BFPJfPx4J6Ui8BR03fAvR8X1wCrKhakUjQ-3D
Home |
Main Index |
Thread Index |
Old Index