Subject: Re: CVS commit: src/lib/libc/arch/i386/string
To: Matthias Drochner <M.Drochner@fz-juelich.de>
From: David Laight <david@l8s.co.uk>
List: current-users
Date: 02/04/2005 19:43:46
On Fri, Feb 04, 2005 at 02:06:35PM +0100, Matthias Drochner wrote:
>
> skrueger@meinberlikomm.de said:
> > is someone working on http://www.netbsd.org/cgi-bin/
> > query-pr-single.pl?number=25263 ???
>
> I've been running these implementations on my main development
> box for many months, without problems.
I looked at the sources last night
- they probably shouldn't have been committed...
Those routines will core dump when given a string that ends on the last
byte of a page, and when the following page isn't mapped.
Also the optimisation '(word32 - 0x01010101) & 0x80808080' is only
valid for 7-bit ascii data. For 8-bit data it is rather pointless.
David
--
David Laight: david@l8s.co.uk