Re: autoconfiguration error

["Jonathan A. Kollasch" <jakllsch%kollasch.net@localhost>]

On Tue, Jun 12, 2018 at 12:13:27PM +0100, Patrick Welche wrote:
> I haven't seen "autoconfiguration error" before - something to worry about?
> (native X works fine)
On Tue, Jun 12, 2018 at 07:40:30PM +0700, Robert Elz wrote:
>     Date:        Tue, 12 Jun 2018 12:13:27 +0100
>     From:        Patrick Welche <prlw1%cam.ac.uk@localhost>
>     Message-ID:  <20180612111327.GA2775@quartz>
> 
>   | I haven't seen "autoconfiguration error" before - something to worry about?
> 
> No, just an extra couple of words that were added to those messages
> to make them easier to spot (easier to grep for.)
> 
> kre
> 

As kre says.  It was nearly impossible to spot what caused the
aprint(9) error count to be incremented.  That made the "WARNING:
%d error%s while detecting hardware; check system log.\n" message from
config_finalize() very difficult diagnose in the cases where the error
message isn't worded ominously enough—a not-uncommon occurrence.

Perhaps we might want to revise this extra sentinel and/or the error
summary to only occur in the log with AB_VERBOSE or AB_DEBUG in
boothowto, or DIAGNOSTIC or DEBUG option enabled.  That or we can fix
the most superfluous aprint_error() callers.

	Jonathan Kollasch