[pkgsrc/trunk]: pkgsrc/devel/gdb gdb: remove incorrect patch

[mcf <mcf%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/a81ba59a57d6
branches:  trunk
changeset: 441089:a81ba59a57d6
user:      mcf <mcf%pkgsrc.org@localhost>
date:      Mon Oct 26 04:26:11 2020 +0000

description:
gdb: remove incorrect patch

This patch originates from pkgsrc-wip in order to prevent clang
warnings for adding an integer to a string literal by converting
"foo" + x to &"foo"[x]. However, when gdb was updated to 7.9, the
ampersand was mistakenly dropped. The string literal was also
replaced with a variable, so there is no longer any reason for the
patch.

This caused the oappend function to be called with a char converted
to a pointer, which immediately crashes gdb whenever disassembly
is performed.

diffstat:

 devel/gdb/Makefile                         |   3 ++-
 devel/gdb/distinfo                         |   3 +--
 devel/gdb/patches/patch-opcodes_i386-dis_c |  13 -------------
 3 files changed, 3 insertions(+), 16 deletions(-)

diffs (42 lines):

diff -r 3096d91d4468 -r a81ba59a57d6 devel/gdb/Makefile
--- a/devel/gdb/Makefile        Mon Oct 26 03:21:05 2020 +0000
+++ b/devel/gdb/Makefile        Mon Oct 26 04:26:11 2020 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.74 2020/10/26 03:21:05 mcf Exp $
+# $NetBSD: Makefile,v 1.75 2020/10/26 04:26:11 mcf Exp $
 
 DISTNAME=      gdb-10.1
+PKGREVISION=   1
 CATEGORIES=    devel
 MASTER_SITES=  ${MASTER_SITE_GNU:=gdb/}
 
diff -r 3096d91d4468 -r a81ba59a57d6 devel/gdb/distinfo
--- a/devel/gdb/distinfo        Mon Oct 26 03:21:05 2020 +0000
+++ b/devel/gdb/distinfo        Mon Oct 26 04:26:11 2020 +0000
@@ -1,8 +1,7 @@
-$NetBSD: distinfo,v 1.36 2020/10/24 18:22:08 kamil Exp $
+$NetBSD: distinfo,v 1.37 2020/10/26 04:26:11 mcf Exp $
 
 SHA1 (gdb-10.1.tar.gz) = 5218b83c33acd27ec4e62690baaf555503fdccd5
 RMD160 (gdb-10.1.tar.gz) = 87163d96863e4923691f0c1bd34f58e30f2685e8
 SHA512 (gdb-10.1.tar.gz) = 41b50955f82780a1935294669a14eca40e58574ad4aa6d476903b729605f09930e5bb651b4de0c49b948d65fdf521a4b7f22c5d3b1f83dd6c9a15957c9d52370
 Size (gdb-10.1.tar.gz) = 40245323 bytes
 SHA1 (patch-gdb_doc_Makefile.in) = f7205fe715779e8aed05d230d43320286f74fdd0
-SHA1 (patch-opcodes_i386-dis_c) = 57b2b2ce85567faf112ec9f435b9aed0ffc943fb
diff -r 3096d91d4468 -r a81ba59a57d6 devel/gdb/patches/patch-opcodes_i386-dis_c
--- a/devel/gdb/patches/patch-opcodes_i386-dis_c        Mon Oct 26 03:21:05 2020 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,13 +0,0 @@
-$NetBSD: patch-opcodes_i386-dis_c,v 1.1 2015/03/15 14:56:46 bsiegert Exp $
-
---- opcodes/i386-dis.c.orig    2015-02-19 11:58:08.000000000 +0000
-+++ opcodes/i386-dis.c
-@@ -13586,7 +13586,7 @@ dofloat (int sizeflag)
- static void
- oappend_maybe_intel (const char *s)
- {
--  oappend (s + intel_syntax);
-+  oappend (s[(short)intel_syntax]);
- }
- 
- static void