[pkgsrc/trunk]: pkgsrc/sysutils/intel-backlight intel-backlight: don't set SE...

[tnn <tnn%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/81aee653ea3a
branches:  trunk
changeset: 449755:81aee653ea3a
user:      tnn <tnn%pkgsrc.org@localhost>
date:      Mon Apr 05 10:18:36 2021 +0000

description:
intel-backlight: don't set SETUID_ROOT_PERMS when UNPRIVILEGED

Requested by nia@.
In unprivileged installations the binary becomes setuid to the
unprivileged user so it doesn't work even when ran as root via sudo,
due to privilege dropping upon execution.

XXX: Arguably this fix is wrong. It doesn't make sense to me that pkgsrc
infrastructure uses mode 4511 in SETUID_ROOT_PERMS when UNPRIVILEGED.

diffstat:

 sysutils/intel-backlight/Makefile |  6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diffs (21 lines):

diff -r 11548b0ecb30 -r 81aee653ea3a sysutils/intel-backlight/Makefile
--- a/sysutils/intel-backlight/Makefile Mon Apr 05 10:17:42 2021 +0000
+++ b/sysutils/intel-backlight/Makefile Mon Apr 05 10:18:36 2021 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2021/04/04 10:52:40 tnn Exp $
+# $NetBSD: Makefile,v 1.3 2021/04/05 10:18:36 tnn Exp $
 
 DISTNAME=      intel_backlight_fbsd-20200418
 PKGREVISION=   1
@@ -25,7 +25,11 @@
 INSTALLATION_DIRS+=    sbin
 INSTALLATION_DIRS+=    ${PKGMANDIR}/man1
 
+.include "../../mk/bsd.prefs.mk"
+
+.if empty(UNPRIVILEGED:MM[yY][eE][sS])
 SPECIAL_PERMS+=        sbin/intel_backlight ${SETUID_ROOT_PERMS}
+.endif
 
 do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/intel_backlight \