pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/mk properly quote the value of PKGNAME_REQD when calli...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/aceacb2856f4
branches:  trunk
changeset: 462870:aceacb2856f4
user:      grant <grant%pkgsrc.org@localhost>
date:      Sat Oct 18 05:23:48 2003 +0000

description:
properly quote the value of PKGNAME_REQD when calling ${MAKE} to
build a dependency so that the shell does not attempt to do
interpret the value of PKGNAME_REQD.

noticed on Linux building graphics/mplayer where the build of
audio/nas was broken because ${MAKE} was being called with
PKGNAME_REQD=nas>=1.4.2 instead of PKGNAME_REQD="nas>=1.4.2"

diffstat:

 mk/bsd.pkg.mk |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (18 lines):

diff -r 7857b2348f57 -r aceacb2856f4 mk/bsd.pkg.mk
--- a/mk/bsd.pkg.mk     Sat Oct 18 04:00:48 2003 +0000
+++ b/mk/bsd.pkg.mk     Sat Oct 18 05:23:48 2003 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: bsd.pkg.mk,v 1.1295 2003/10/11 05:09:39 grant Exp $
+#      $NetBSD: bsd.pkg.mk,v 1.1296 2003/10/18 05:23:48 grant Exp $
 #
 # This file is in the public domain.
 #
@@ -4017,7 +4017,7 @@
                        ${ECHO_MSG} "=> No directory for $$dir.  Skipping.."; \
                else                                                    \
                        cd $$dir ;                                      \
-                       ${MAKE} ${MAKEFLAGS} $$target _PKGSRC_DEPS=", ${PKGNAME}${_PKGSRC_DEPS}" PKGNAME_REQD="$$pkg"; \
+                       ${MAKE} ${MAKEFLAGS} $$target _PKGSRC_DEPS=", ${PKGNAME}${_PKGSRC_DEPS}" PKGNAME_REQD=\""$$pkg"\"; \
                        ${ECHO_MSG} "${_PKGSRC_IN}> Returning to build of ${PKGNAME}"; \
                fi;                                                     \
        fi



Home | Main Index | Thread Index | Old Index