pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Only warn about use of $(VARIAB...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/12b48f1e2d31
branches:  trunk
changeset: 494314:12b48f1e2d31
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Mon May 23 06:47:11 2005 +0000

description:
Only warn about use of $(VARIABLE) if it is not preceded by another $.
This avoids false positives in sed(1) expressions.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r ab8a3eeaaf1e -r 12b48f1e2d31 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Mon May 23 06:41:54 2005 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Mon May 23 06:47:11 2005 +0000
@@ -11,7 +11,7 @@
 # Freely redistributable.  Absolutely no warranty.
 #
 # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp
-# $NetBSD: pkglint.pl,v 1.169 2005/05/23 00:10:42 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.170 2005/05/23 06:47:11 rillig Exp $
 #
 # This version contains lots of changes necessary for NetBSD packages
 # done by:
@@ -1264,7 +1264,7 @@
        #
        if ($opt_warn_paren) {
                log_info(NO_FILE, NO_LINE_NUMBER, "Checking for \$(VARIABLE).");
-               if ($whole =~ /\$\([\w\d]+\)/) {
+               if ($whole =~ /[^\$]\$\([\w\d]+\)/) {
                        log_warning(NO_FILE, NO_LINE_NUMBER, "Use \${VARIABLE} instead of \$(VARIABLE).");
                }
        }



Home | Main Index | Thread Index | Old Index