pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc Updated pkglint to 4.27.



details:   https://anonhg.NetBSD.org/pkgsrc/rev/f9dd52a91b75
branches:  trunk
changeset: 500801:f9dd52a91b75
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Thu Oct 13 00:23:53 2005 +0000

description:
Updated pkglint to 4.27.

Added a warning that ${PKGNAME} and ${PKGVERSION} should not be used in
some other variables, as they may contain the PKGREVISION.

diffstat:

 doc/CHANGES                       |   3 ++-
 pkgtools/pkglint/Makefile         |   4 ++--
 pkgtools/pkglint/files/pkglint.pl |  13 ++++++++++++-
 3 files changed, 16 insertions(+), 4 deletions(-)

diffs (57 lines):

diff -r 30819527747d -r f9dd52a91b75 doc/CHANGES
--- a/doc/CHANGES       Wed Oct 12 22:27:49 2005 +0000
+++ b/doc/CHANGES       Thu Oct 13 00:23:53 2005 +0000
@@ -1,4 +1,4 @@
-$NetBSD: CHANGES,v 1.11445 2005/10/12 22:27:49 wiz Exp $
+$NetBSD: CHANGES,v 1.11446 2005/10/13 00:24:41 rillig Exp $
 
 Changes to the packages collection and infrastructure in 2005:
 
@@ -4473,3 +4473,4 @@
        Updated meta-pkgs/gnome-base to 2.12.1 [jmmv 2005-10-12]
        Added misc/kmemaid version 0.4.7.0 [wiz 2005-10-12]
        Updated audio/icecast to 2.3.0 [wiz 2005-10-12]
+       Updated pkgtools/pkglint to 4.27 [rillig 2005-10-13]
diff -r 30819527747d -r f9dd52a91b75 pkgtools/pkglint/Makefile
--- a/pkgtools/pkglint/Makefile Wed Oct 12 22:27:49 2005 +0000
+++ b/pkgtools/pkglint/Makefile Thu Oct 13 00:23:53 2005 +0000
@@ -1,7 +1,7 @@
-# $NetBSD: Makefile,v 1.262 2005/10/09 18:24:11 rillig Exp $
+# $NetBSD: Makefile,v 1.263 2005/10/13 00:23:53 rillig Exp $
 #
 
-DISTNAME=      pkglint-4.26
+DISTNAME=      pkglint-4.27
 CATEGORIES=    pkgtools devel
 MASTER_SITES=  # empty
 DISTFILES=     # empty
diff -r 30819527747d -r f9dd52a91b75 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Wed Oct 12 22:27:49 2005 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Thu Oct 13 00:23:53 2005 +0000
@@ -11,7 +11,7 @@
 # Freely redistributable.  Absolutely no warranty.
 #
 # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp
-# $NetBSD: pkglint.pl,v 1.296 2005/10/09 18:24:11 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.297 2005/10/13 00:23:53 rillig Exp $
 #
 # This version contains lots of changes necessary for NetBSD packages
 # done by:
@@ -1543,6 +1543,17 @@
                        if ($varname =~ qr"^SUBST_STAGE\." && $value !~ qr"^(?:pre|do|post)-(?:patch|configure|build|install)$") {
                                $line->log_warning("SUBST_STAGE should be one of {pre,do,post}-{patch,configure,build,install}");
                        }
+
+                       if ($value =~ qr"\$\{(PKGNAME|PKGVERSION)[:\}]") {
+                               my ($pkgvarname) = ($1);
+                               if ($varname =~ qr"^PKG_.*_REASON$") {
+                                       # ok
+                               } elsif ($varname =~ qr"^(?:DIST_SUBDIR|WRKSRC)$") {
+                                       $line->log_warning("${pkgvarname} should not be used in ${varname}, as it sometimes includes the PKGREVISION. Please use ${pkgvarname}_NOREV instead.");
+                               } else {
+                                       $line->log_info("Use of PKGNAME in ${varname}.");
+                               }
+                       }
                }
        }
 



Home | Main Index | Thread Index | Old Index