[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files - The heuristics for unnecessar...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/fde410987ef5
branches:  trunk
changeset: 504151:fde410987ef5
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Mon Dec 05 21:56:13 2005 +0000

description:
- The heuristics for unnecessary .undef directives after .for were
  unreliable, hence they are not fixed (deleted) automatically.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diffs (30 lines):

diff -r bc4f68a8f1f0 -r fde410987ef5 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Mon Dec 05 21:46:18 2005 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Mon Dec 05 21:56:13 2005 +0000
@@ -11,7 +11,7 @@
 # Freely redistributable.  Absolutely no warranty.
 #
 # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp
-# $NetBSD: pkglint.pl,v 1.415 2005/12/05 21:46:18 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.416 2005/12/05 21:56:13 rillig Exp $
 #
 # This version contains lots of changes necessary for NetBSD packages
 # done by:
@@ -2750,17 +2750,11 @@
                                }
 
                        } elsif ($directive eq "undef" && defined($args)) {
-                               my $all_unnecessary = true;
                                foreach my $var (split(qr"\s+", $args)) {
                                        if (exists($for_variables->{$var})) {
                                                $line->log_note("Using \".undef\" after a \".for\" loop is unnecessary.");
-                                       } else {
-                                               $all_unnecessary = false;
                                        }
                                }
-                               if ($all_unnecessary) {
-                                       $line->delete();
-                               }
                        }
 
                } elsif ($text =~ regex_mk_dependency) {