[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files In the SCST_COND state, a shell...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/2cd9fc875c7c
branches:  trunk
changeset: 514234:2cd9fc875c7c
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Jun 09 08:53:28 2006 +0000

description:
In the SCST_COND state, a shell command is expected, so check here for
known and unknown commands, too.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r 3953fe746ec7 -r 2cd9fc875c7c pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Fri Jun 09 08:50:24 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Fri Jun 09 08:53:28 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.616 2006/06/08 18:22:46 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.617 2006/06/09 08:53:28 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -3436,7 +3436,7 @@
                # and the symbol on the "input tape".
                #
 
-               if ($state == SCST_START && exists($vartools->{$shellword})) {
+               if (($state == SCST_START || $state == SCST_COND) && exists($vartools->{$shellword})) {
                        my $addition = "";
 
                        if (!exists(get_predefined_vartool_names()->{$shellword})) {
@@ -3447,7 +3447,7 @@
                        $line->log_warning("Direct use of tool \"${shellword}\". Please use \$\{$vartools->{$shellword}\} instead${addition}.");
                }
 
-               if ($state == SCST_START) {
+               if ($state == SCST_START || $state == SCST_COND) {
                        if (exists(forbidden_commands->{$shellword})) {
                                $line->log_error("${shellword} is forbidden and must not be used.");