[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files When checking a Pathlist, split...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/0bc1ed99d8d1
branches:  trunk
changeset: 514807:0bc1ed99d8d1
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sun Jun 18 08:43:35 2006 +0000

description:
When checking a Pathlist, split $value instead of $value_novar. This avoids
many false positive warnings for paths like ${PREFIX}/foo.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r 3d8a59e9e9e9 -r 0bc1ed99d8d1 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Sun Jun 18 08:42:16 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Sun Jun 18 08:43:35 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.632 2006/06/18 08:20:19 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.633 2006/06/18 08:43:35 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -4185,7 +4185,9 @@
                }
 
        } elsif ($type eq "Pathlist") {
-               my (@paths) = split(qr":", $value_novar);
+               # XXX: The splitting will fail if $value contains any
+               # variables with modifiers, for example :Q or :S/././.
+               my (@paths) = split(qr":", $value);
 
                foreach my $p (@paths) {
                        checkline_mk_vartype_basic($line, $varname, "Pathname", $op, $p, $comment, false);