[pkgsrc/trunk]: pkgsrc/mail/clamsmtp - Some "pkglint -Wall" fixes

[martti <martti%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/911c9f8754b0
branches:  trunk
changeset: 537467:911c9f8754b0
user:      martti <martti%pkgsrc.org@localhost>
date:      Wed Jan 09 14:10:06 2008 +0000

description:
- Some "pkglint -Wall" fixes
- Make this build on Solaris 10 by checking for strcasestr (patch received
  from Andri Piik in a private mail)

diffstat:

 mail/clamsmtp/Makefile         |  13 ++++++++++---
 mail/clamsmtp/distinfo         |   8 +++++---
 mail/clamsmtp/patches/patch-aa |   4 +++-
 mail/clamsmtp/patches/patch-ab |   4 +++-
 mail/clamsmtp/patches/patch-ac |  15 +++++++++++++++
 mail/clamsmtp/patches/patch-ad |  41 +++++++++++++++++++++++++++++++++++++++++
 6 files changed, 77 insertions(+), 8 deletions(-)

diffs (140 lines):

diff -r 0bcddcfc79a5 -r 911c9f8754b0 mail/clamsmtp/Makefile
--- a/mail/clamsmtp/Makefile    Wed Jan 09 13:47:42 2008 +0000
+++ b/mail/clamsmtp/Makefile    Wed Jan 09 14:10:06 2008 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.36 2007/12/02 13:04:10 wiz Exp $
+# $NetBSD: Makefile,v 1.37 2008/01/09 14:10:06 martti Exp $
 
 DISTNAME=              clamsmtp-1.8
 PKGREVISION=           3
@@ -12,11 +12,12 @@
 
 PKG_INSTALLATION_TYPES=        overwrite pkgviews
 
+USE_TOOLS+=            aclocal autoconf autoheader automake
 GNU_CONFIGURE=         yes
 RCD_SCRIPTS=           clamsmtpd
 
 MESSAGE_SUBST+=                HOMEPAGE=${HOMEPAGE}
-FILES_SUBST+=          CLAMAV_USER=${CLAMAV_USER:Q}
+FILES_SUBST+=          CLAMAV_USER=${CLAMAV_USER}
 
 # Doesn't work with GNU pth (missing required mutex features)
 PTHREAD_OPTS+=         require native
@@ -27,7 +28,13 @@
 
 INSTALLATION_DIRS=     share/examples/${PKGBASE}
 
-PKG_USERS_VARS+=       CLAMAV_USER
+PKG_USERS_VARS=                CLAMAV_USER
+
+pre-configure:
+       cd ${WRKSRC} && aclocal
+       cd ${WRKSRC} && autoheader
+       cd ${WRKSRC} && automake -a --foreign -i
+       cd ${WRKSRC} && autoconf
 
 post-install:
        ${INSTALL_DATA} ${WRKSRC}/doc/clamsmtpd.conf ${EGDIR}
diff -r 0bcddcfc79a5 -r 911c9f8754b0 mail/clamsmtp/distinfo
--- a/mail/clamsmtp/distinfo    Wed Jan 09 13:47:42 2008 +0000
+++ b/mail/clamsmtp/distinfo    Wed Jan 09 14:10:06 2008 +0000
@@ -1,7 +1,9 @@
-$NetBSD: distinfo,v 1.20 2006/10/27 17:37:18 xtraeme Exp $
+$NetBSD: distinfo,v 1.21 2008/01/09 14:10:06 martti Exp $
 
 SHA1 (clamsmtp-1.8.tar.gz) = ad12dce1355f5e57a7e2a216795287145a5e566a
 RMD160 (clamsmtp-1.8.tar.gz) = f80745af5628f8058d591f7f1636ae2f0a88c2f0
 Size (clamsmtp-1.8.tar.gz) = 184285 bytes
-SHA1 (patch-aa) = 4a59000b6c9ca4dfcfa37e125f620a5f674beafa
-SHA1 (patch-ab) = ec4533d12bfcd52188575deb87a1d260a92b8cbd
+SHA1 (patch-aa) = f2ae4507b333816591b0c7f49c5e4ed16e4e4f95
+SHA1 (patch-ab) = 489aae100fb380e83809a9896a36265de9a09ef9
+SHA1 (patch-ac) = 7c367fd8a2bbbc86a2c11feec31d56ae615d036a
+SHA1 (patch-ad) = cfc10685789ae19f90e3611c1492e5c8d35668db
diff -r 0bcddcfc79a5 -r 911c9f8754b0 mail/clamsmtp/patches/patch-aa
--- a/mail/clamsmtp/patches/patch-aa    Wed Jan 09 13:47:42 2008 +0000
+++ b/mail/clamsmtp/patches/patch-aa    Wed Jan 09 14:10:06 2008 +0000
@@ -1,4 +1,6 @@
-$NetBSD: patch-aa,v 1.1 2006/04/08 21:56:56 ghen Exp $
+$NetBSD: patch-aa,v 1.2 2008/01/09 14:10:06 martti Exp $
+
+The default clamd socket as defined in pkgsrc/mail/clamav/files/clamd.sh
 
 --- doc/clamsmtpd.conf.orig    2006-04-06 16:42:26.000000000 +0200
 +++ doc/clamsmtpd.conf
diff -r 0bcddcfc79a5 -r 911c9f8754b0 mail/clamsmtp/patches/patch-ab
--- a/mail/clamsmtp/patches/patch-ab    Wed Jan 09 13:47:42 2008 +0000
+++ b/mail/clamsmtp/patches/patch-ab    Wed Jan 09 14:10:06 2008 +0000
@@ -1,4 +1,6 @@
-$NetBSD: patch-ab,v 1.2 2006/08/25 06:31:00 xtraeme Exp $
+$NetBSD: patch-ab,v 1.3 2008/01/09 14:10:06 martti Exp $
+
+The default clamd socket as defined in pkgsrc/mail/clamav/files/clamd.sh
 
 --- src/clamsmtpd.c.orig       2006-08-25 08:26:44.000000000 +0200
 +++ src/clamsmtpd.c    2006-08-25 08:26:59.000000000 +0200
diff -r 0bcddcfc79a5 -r 911c9f8754b0 mail/clamsmtp/patches/patch-ac
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/mail/clamsmtp/patches/patch-ac    Wed Jan 09 14:10:06 2008 +0000
@@ -0,0 +1,15 @@
+$NetBSD: patch-ac,v 1.1 2008/01/09 14:10:06 martti Exp $
+
+Check for strcasestr. We provide an implementation for it if needed.
+
+--- configure.in.orig  2007-12-31 12:16:35.544370000 +0200
++++ configure.in       2007-12-31 12:34:53.195760000 +0200
+@@ -106,7 +106,7 @@
+ # Required Functions
+ AC_CHECK_FUNCS([memset strerror malloc realloc getopt strchr tolower getaddrinfo], , 
+            [echo "ERROR: Required function missing"; exit 1])
+-AC_CHECK_FUNCS([strlwr strlcat strlcpy strncat strncpy setenv daemon])
++AC_CHECK_FUNCS([strlwr strlcat strlcpy strncat strncpy setenv daemon strcasestr])
+ AC_CHECK_FUNCS([getline getdelim flockfile])
+ 
+ # DMALLOC memory debugging
diff -r 0bcddcfc79a5 -r 911c9f8754b0 mail/clamsmtp/patches/patch-ad
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/mail/clamsmtp/patches/patch-ad    Wed Jan 09 14:10:06 2008 +0000
@@ -0,0 +1,41 @@
+$NetBSD: patch-ad,v 1.1 2008/01/09 14:10:07 martti Exp $
+
+Check for strcasestr. We provide an implementation for it if needed.
+
+--- common/smtppass.c.orig     2006-08-30 20:45:57.000000000 +0300
++++ common/smtppass.c  2007-12-31 12:45:35.075661000 +0200
+@@ -206,6 +206,13 @@
+ static const char* get_successful_rsp(const char* line, int* cont);
+ static void do_server_noop(spctx_t* ctx);
+ 
++/*------------------------------------------------------
++ *Added to support systems without strcasestr
++ */
++#ifndef HAVE_STRCASESTR
++char *strcasestr(const char *big, const char *little);
++#endif
++ 
+ /* Used externally in some cases */
+ int sp_parse_option(const char* name, const char* option);
+ 
+@@ -2069,3 +2076,20 @@
+     return 0;
+ }        
+ 
++#ifndef HAVE_STRCASESTR
++char *strcasestr(const char *big, const char *little)
++{
++    int blen;
++    int llen;
++    blen = strlen(big);
++    llen = strlen(little);
++    while (blen >= llen) {
++        if (strncasecmp(big, little, llen) == 0)
++            return (char *)big;
++        big++;
++        blen--;
++    }
++    
++    return NULL;
++}
++#endif