[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files In patch files, comments are so...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/e61507d11569
branches:  trunk
changeset: 576654:e61507d11569
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Tue Jun 15 22:06:48 2010 +0000

description:
In patch files, comments are so useful that this is no longer a
warning that only applies when -Wextra is given.

ok wiz@

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (42 lines):

diff -r 6ba16693b87f -r e61507d11569 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Tue Jun 15 21:29:25 2010 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Tue Jun 15 22:06:48 2010 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.822 2010/03/10 14:42:22 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.823 2010/06/15 22:06:48 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -7387,12 +7387,12 @@
                        #
                }], [PST_TEXT, re_patch_cfd, PST_CFA, sub() {
                        if (!$seen_comment) {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               $line->log_warning("Comment expected.");
                        }
                        $line->log_warning("Please use unified diffs (diff -u) for patches.");
                }], [PST_TEXT, re_patch_ufd, PST_UFA, sub() {
                        if (!$seen_comment) {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               $line->log_warning("Comment expected.");
                        }
                }], [PST_TEXT, re_patch_text, PST_TEXT, sub() {
                        $seen_comment = true;
@@ -7404,14 +7404,14 @@
                        if ($seen_comment) {
                                $opt_warn_space and $line->log_note("Empty line expected.");
                        } else {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               $line->log_warning("Comment expected.");
                        }
                        $line->log_warning("Please use unified diffs (diff -u) for patches.");
                }], [PST_CENTER, re_patch_ufd, PST_UFA, sub() {
                        if ($seen_comment) {
                                $opt_warn_space and $line->log_note("Empty line expected.");
                        } else {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               $line->log_warning("Comment expected.");
                        }
                }], [PST_CENTER, undef, PST_TEXT, sub() {
                        $opt_warn_space and $line->log_note("Empty line expected.");