[pkgsrc/trunk]: pkgsrc/graphics/netpbm Revert the shell used to run netpbm co...

[gson <gson%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/584b828eac01
branches:  trunk
changeset: 639883:584b828eac01
user:      gson <gson%pkgsrc.org@localhost>
date:      Mon Sep 29 18:16:41 2014 +0000

description:
Revert the shell used to run netpbm commands implemented as shell
scripts from bash to sh, to limit exposure to any still-unfixed or
still-undiscovered bash vulnerabilities.

A quick review of the shell scripts did not turn up any obvious
bashishms.  Hopefully they have all been fixed already, but if not,
I'd still rather have one or two scripts be broken (and volunteer to
fix any breakage reported) than have all of them be vulnerable to bash
bugs.

Approved by agc.

diffstat:

 graphics/netpbm/Makefile |  20 +++-----------------
 1 files changed, 3 insertions(+), 17 deletions(-)

diffs (43 lines):

diff -r 4f09f1c7c498 -r 584b828eac01 graphics/netpbm/Makefile
--- a/graphics/netpbm/Makefile  Mon Sep 29 15:11:43 2014 +0000
+++ b/graphics/netpbm/Makefile  Mon Sep 29 18:16:41 2014 +0000
@@ -1,7 +1,7 @@
-# $NetBSD: Makefile,v 1.193 2014/09/19 08:42:47 wiz Exp $
+# $NetBSD: Makefile,v 1.194 2014/09/29 18:16:41 gson Exp $
 
 DISTNAME=      netpbm-10.67.05
-PKGREVISION=   1
+PKGREVISION=   2
 CATEGORIES=    graphics
 MASTER_SITES=  #
 # manually created from svn checkout of
@@ -19,7 +19,7 @@
 COMMENT=       Toolkit for conversion of images between different formats
 LICENSE=       gnu-gpl-v2
 
-USE_TOOLS+=    bash:run gmake lex pax perl
+USE_TOOLS+=    gmake lex pax perl
 USE_FEATURES=  snprintf
 
 INSTALL_TARGET=        install-dev install-run
@@ -39,20 +39,6 @@
 
 WRAPPER_REORDER_CMDS+= reorder:l:rle:netpbm
 
-# Several of the netpbm shell scripts use bashisms, so force using
-# bash for all of the shell scripts.
-REPLACE_INTERPRETER+=  bash
-REPLACE.bash.old=      .*/bin/sh
-REPLACE.bash.new=      ${TOOLS_PATH.bash}
-REPLACE_FILES.bash=    converter/other/anytopnm
-REPLACE_FILES.bash+=   converter/other/pnmtoplainpnm
-REPLACE_FILES.bash+=   converter/ppm/hpcdtoppm/hpcdtoppm
-REPLACE_FILES.bash+=   converter/ppm/hpcdtoppm/pcdovtoppm
-REPLACE_FILES.bash+=   editor/pamstretch-gen
-REPLACE_FILES.bash+=   editor/pnmindex.sh
-REPLACE_FILES.bash+=   editor/pnmmargin
-REPLACE_FILES.bash+=   other/ppmtomap
-
 SUBST_CLASSES+=                rgb_txt
 SUBST_STAGE.rgb_txt=   post-patch
 SUBST_MESSAGE.rgb_txt= Configure RGB_TXT