[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Removed the -Winternal flag and...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/a8b5b91d3fc0
branches:  trunk
changeset: 498769:a8b5b91d3fc0
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Sep 02 22:45:31 2005 +0000

description:
Removed the -Winternal flag and the checks for the ":=" operator. There had
been too many spurious warnings to be worth the effort.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  17 +----------------
 1 files changed, 1 insertions(+), 16 deletions(-)

diffs (48 lines):

diff -r ec66b967dad0 -r a8b5b91d3fc0 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Fri Sep 02 19:29:56 2005 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Fri Sep 02 22:45:31 2005 +0000
@@ -11,7 +11,7 @@
 # Freely redistributable.  Absolutely no warranty.
 #
 # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp
-# $NetBSD: pkglint.pl,v 1.270 2005/09/02 12:39:42 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.271 2005/09/02 22:45:31 rillig Exp $
 #
 # This version contains lots of changes necessary for NetBSD packages
 # done by:
@@ -328,7 +328,6 @@
 my $opt_warn_absname   = true;
 my $opt_warn_directcmd = true;
 my $opt_warn_exec      = true;
-my $opt_warn_internal  = false;
 my $opt_warn_order     = true;
 my $opt_warn_paren     = true;
 my $opt_warn_plist_sort        = false;
@@ -339,7 +338,6 @@
        "absname"       => [\$opt_warn_absname, "warn about use of absolute file names"],
        "directcmd"     => [\$opt_warn_directcmd, "warn about use of direct command names instead of Make variables"],
        "exec"          => [\$opt_warn_exec, "warn if source files are executable"],
-       "internal"      => [\$opt_warn_internal, "emit warnings for the pkgsrc infrastructure files"],
        "order"         => [\$opt_warn_order, "warn if Makefile entries are unordered"],
        "paren"         => [\$opt_warn_paren, "warn about use of \$(VAR) instead of \${VAR} in Makefiles"],
        "plist-sort"    => [\$opt_warn_plist_sort, "warn about unsorted entries in PLISTs"],
@@ -1347,19 +1345,6 @@
                if ($text =~ /^\040{8}/) {
                        $line->log_warning("Use tab (not spaces) to make indentation.");
                }
-
-               if ($text =~ $regex_varassign) {
-                       my ($varname, $op, $value) = ($1, $2, $3);
-
-                       if ($op eq ":=") {
-                               if ($line->file =~ qr"buildlink3.mk$" && $varname =~ "BUILDLINK") {
-                                       # buildlink3 files may use the := operator
-
-                               } elsif ($opt_warn_internal || $line->file !~ qr"/mk/") {
-                                       $line->log_warning("Please use \"=\" instead of \":=\" if possible.");
-                               }
-                       }
-               }
        }
 
        checklines_trailing_empty_lines($lines);