[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Variable names starting with an...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/5bb6e2cdcca4
branches:  trunk
changeset: 503396:5bb6e2cdcca4
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sat Nov 19 19:28:06 2005 +0000

description:
Variable names starting with an underscore are reserved for internal
pkgsrc use.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (22 lines):

diff -r 0eb6b364b32d -r 5bb6e2cdcca4 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Sat Nov 19 19:21:47 2005 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Sat Nov 19 19:28:06 2005 +0000
@@ -11,7 +11,7 @@
 # Freely redistributable.  Absolutely no warranty.
 #
 # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp
-# $NetBSD: pkglint.pl,v 1.367 2005/11/19 19:18:56 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.368 2005/11/19 19:28:06 rillig Exp $
 #
 # This version contains lots of changes necessary for NetBSD packages
 # done by:
@@ -2195,8 +2195,7 @@
                        my ($varname, $op, $value, $comment) = ($1, $2, $3, $4);
 
                        if ($varname =~ qr"^_") {
-                               # TODO: enable this when lang/perl5 has been fixed.
-                               #$line->log_error("Variable names starting with an underscore are reserved for internal pkgsrc use.");
+                               $line->log_error("Variable names starting with an underscore are reserved for internal pkgsrc use.");
                        }
 
                        if ($varname eq "PERL5_PACKLIST" && defined($pkgname) && $pkgname =~ qr"^p5-(.*)-[0-9].*") {