pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Some minor refinements.



details:   https://anonhg.NetBSD.org/pkgsrc/rev/cb2a7a2e28c3
branches:  trunk
changeset: 515580:cb2a7a2e28c3
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Tue Jul 04 09:29:54 2006 +0000

description:
Some minor refinements.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diffs (29 lines):

diff -r 4cb8b08a2ef9 -r cb2a7a2e28c3 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Tue Jul 04 09:20:18 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Tue Jul 04 09:29:54 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.635 2006/07/04 09:02:16 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.636 2006/07/04 09:29:54 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -1418,6 +1418,9 @@
        }
 
        if ($varparam ne $id) {
+
+               # XXX: This code sometimes produces weird warnings. See
+               # meta-pkgs/xorg/Makefile.common 1.41 for an example.
                if ($self->is_complete()) {
                        $self->check_end();
 
@@ -4622,7 +4625,7 @@
                                }
 
                                if ($p !~ qr"^[\$/]") {
-                                       $line->log_warning("\"${p}\" should be an absolute path.");
+                                       $line->log_warning("All components of ${varname} (in this case \"${p}\")should be an absolute path.");
                                }
                        }
                }



Home | Main Index | Thread Index | Old Index