[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files - Defining and using make varia...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/cf5ec1cf4894
branches:  trunk
changeset: 506121:cf5ec1cf4894
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Thu Jan 12 10:39:30 2006 +0000

description:
- Defining and using make variables starting with an underscore is only
  worth a warning, not an error. There are worse things at the moment that
  need to be fixed.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r da98d5984cb8 -r cf5ec1cf4894 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Thu Jan 12 10:32:40 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Thu Jan 12 10:39:30 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@ -w
-# $NetBSD: pkglint.pl,v 1.465 2006/01/12 10:32:40 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.466 2006/01/12 10:39:30 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -2676,7 +2676,7 @@
        checkline_mk_vartype($line, $varname, $op, $value, $comment);
 
        if (!$is_internal && $varname =~ qr"^_") {
-               $line->log_error("Variable names starting with an underscore are reserved for internal pkgsrc use.");
+               $line->log_warning("Variable names starting with an underscore are reserved for internal pkgsrc use.");
        }
 
        if ($varname eq "PERL5_PACKLIST" && defined($pkgname) && $pkgname !~ regex_unresolved && $pkgname =~ qr"^p5-(.*)-[0-9].*") {
@@ -2981,7 +2981,7 @@
 
                                        foreach my $var (split(qr"\s+", $vars)) {
                                                if (!$is_internal && $var =~ qr"^_") {
-                                                       $line->log_error("Variable names starting with an underscore are reserved for internal pkgsrc use.");
+                                                       $line->log_warning("Variable names starting with an underscore are reserved for internal pkgsrc use.");
                                                }
 
                                                if ($var =~ qr"^[_a-z][_a-z0-9]*$") {