[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files The absolute pathname /bin/sh i...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/adbb54d1c771
branches:  trunk
changeset: 520246:adbb54d1c771
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Tue Oct 17 21:42:46 2006 +0000

description:
The absolute pathname /bin/sh is allowed, despite the Solaris /bin/sh.

The WRKSRC variable (among others) is checked to consist of ony one
word. The url2pkg tool had created lines like

    WRKSRC=         ${WRKDIR}/Makefile PLIST distinfo

in the past, which happened to work in most cases up to now, but really
shouldn't.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diffs (29 lines):

diff -r 9db4582a18d6 -r adbb54d1c771 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Tue Oct 17 21:32:37 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Tue Oct 17 21:42:46 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.680 2006/10/07 07:57:04 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.681 2006/10/17 21:42:46 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -3514,6 +3514,10 @@
        if ($word =~ qr"^/dev/(?:null|tty|zero)$") {
                # These are defined by POSIX.
 
+       } elsif ($word eq "/bin/sh") {
+               # This is usually correct, although on Solaris, it's pretty
+               # feature-crippled.
+
        } elsif ($word !~ qr"/(?:[a-z]|\$[({])") {
                # Assume that all pathnames start with a lowercase letter.
 
@@ -5312,6 +5316,7 @@
                }
 
        } elsif ($type eq "WrkdirSubdirectory") {
+               checkline_mk_vartype_basic($line, $varname, "Pathname", $op, $value, $comment, $list_context, $is_guessed);
                if ($value eq "\${WRKDIR}") {
                        # Fine.
                } else {