[pkgsrc/trunk]: pkgsrc/mk Don't write ${FOO:Mbar} == "bar", when !empty(FOO:M...

[jlam <jlam%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/76e31b8086f8
branches:  trunk
changeset: 506770:76e31b8086f8
user:      jlam <jlam%pkgsrc.org@localhost>
date:      Sat Jan 21 21:32:51 2006 +0000

description:
Don't write ${FOO:Mbar} == "bar", when !empty(FOO:Mbar) will suffice.
In this case, "FOO" is "INTERACTIVE_STAGE".

diffstat:

 mk/bsd.pkg.extract.mk |   4 ++--
 mk/bsd.pkg.mk         |  10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diffs (63 lines):

diff -r 5a5774133f65 -r 76e31b8086f8 mk/bsd.pkg.extract.mk
--- a/mk/bsd.pkg.extract.mk     Sat Jan 21 20:46:54 2006 +0000
+++ b/mk/bsd.pkg.extract.mk     Sat Jan 21 21:32:51 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.pkg.extract.mk,v 1.18 2006/01/21 19:39:22 jlam Exp $
+# $NetBSD: bsd.pkg.extract.mk,v 1.19 2006/01/21 21:32:51 jlam Exp $
 #
 # This Makefile fragment is included to bsd.pkg.mk and defines the
 # relevant variables and targets for the "extract" phase.
@@ -181,7 +181,7 @@
        ${_RELEASE_LOCK}
 
 ${_EXTRACT_COOKIE}:
-.if ${INTERACTIVE_STAGE:Mextract} == "extract" && defined(BATCH)
+.if !empty(INTERACTIVE_STAGE:Mextract) && defined(BATCH)
        @${ECHO} "*** The extract stage of this package requires user interaction"
        @${ECHO} "*** Please extract manually with \"cd ${PKGDIR} && ${MAKE} extract\""
        @${TOUCH} ${_INTERACTIVE_COOKIE}
diff -r 5a5774133f65 -r 76e31b8086f8 mk/bsd.pkg.mk
--- a/mk/bsd.pkg.mk     Sat Jan 21 20:46:54 2006 +0000
+++ b/mk/bsd.pkg.mk     Sat Jan 21 21:32:51 2006 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: bsd.pkg.mk,v 1.1796 2006/01/21 10:10:42 rillig Exp $
+#      $NetBSD: bsd.pkg.mk,v 1.1797 2006/01/21 21:32:51 jlam Exp $
 #
 # This file is in the public domain.
 #
@@ -1269,7 +1269,7 @@
 .  if !empty(_ALLFILES)
        ${_PKG_SILENT}${_PKG_DEBUG}                                     \
        ${TEST} -d ${_DISTDIR} || ${MKDIR} ${_DISTDIR}
-.    if ${INTERACTIVE_STAGE:Mfetch} == "fetch" && defined(BATCH)
+.    if !empty(INTERACTIVE_STAGE:Mfetch) && defined(BATCH)
        ${_PKG_SILENT}${_PKG_DEBUG}                                     \
        ${MAKE} ${MAKEFLAGS} batch-check-distfiles
 .    else
@@ -2147,7 +2147,7 @@
        "     * It may be removed in the next branch unless fixed."
 .endif
 ${_CONFIGURE_COOKIE}:
-.if ${INTERACTIVE_STAGE:Mconfigure} == "configure" && defined(BATCH)
+.if !empty(INTERACTIVE_STAGE:Mconfigure) && defined(BATCH)
        @${ECHO} "*** The configuration stage of this package requires user interaction"
        @${ECHO} "*** Please configure manually with \"cd ${PKGDIR} && ${MAKE} configure\""
        @${TOUCH} ${_INTERACTIVE_COOKIE}
@@ -2170,7 +2170,7 @@
        "     * It may be removed in the next branch unless fixed."
 .endif
 ${_BUILD_COOKIE}:
-.if ${INTERACTIVE_STAGE:Mbuild} == "build" && defined(BATCH)
+.if !empty(INTERACTIVE_STAGE:Mbuild) && defined(BATCH)
        @${ECHO} "*** The build stage of this package requires user interaction"
        @${ECHO} "*** Please build manually with \"cd ${PKGDIR} && ${MAKE} build\""
        @${TOUCH} ${_INTERACTIVE_COOKIE}
@@ -2183,7 +2183,7 @@
        ${_PKG_SILENT}${_PKG_DEBUG}cd ${.CURDIR} && ${SETENV} ${BUILD_ENV} ${MAKE} ${MAKEFLAGS} real-test PKG_PHASE=test
 
 ${_INSTALL_COOKIE}:
-.if ${INTERACTIVE_STAGE:Minstall} == "install" && defined(BATCH)
+.if !empty(INTERACTIVE_STAGE:Minstall) && defined(BATCH)
        @${ECHO} "*** The installation stage of this package requires user interaction"
        @${ECHO} "*** Please install manually with \"cd ${PKGDIR} && ${MAKE} install\""
        @${TOUCH} ${_INTERACTIVE_COOKIE}