[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files It's not very useful to have em...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/0d2ea715bd72
branches:  trunk
changeset: 534520:0d2ea715bd72
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Thu Oct 25 16:08:48 2007 +0000

description:
It's not very useful to have empty PLIST files, so warn about it. This
may happen when a package has been newly created and the print-PLIST
target has not yet been run.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)

diffs (31 lines):

diff -r 1dbc338bd62d -r 0d2ea715bd72 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Thu Oct 25 16:02:23 2007 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Thu Oct 25 16:08:48 2007 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.721 2007/10/13 08:55:48 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.722 2007/10/25 16:08:48 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -7298,6 +7298,20 @@
        }
        checkline_rcsid($lines->[0], "\@comment ");
 
+       if (@$lines == 1) {
+               $lines->[0]->log_warning("PLIST files shouldn't be empty.");
+               $lines->[0]->explain_warning(
+
+"One reason for empty PLISTs is that this is a newly created package",
+"and that the author didn't run \"bmake print-PLIST\" after installing",
+"the files.",
+"",
+"Another reason, common for Perl packages, is that the PLIST is",
+"automatically generated. Since there is no use of the empty PLIST file,",
+"it shouldn't be necessary. This should be fixed in the pkgsrc",
+"infrastructure.");
+       }
+
        # Get the list of all files from the PLIST.
        $all_files = {};
        foreach my $line (@{$lines}) {