[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Deactivated the "NOTE: you can ...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/47dcb4950111
branches:  trunk
changeset: 537313:47dcb4950111
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sun Jan 06 14:55:00 2008 +0000

description:
Deactivated the "NOTE: you can write "tool" instead of "${TOOL}", as
suggested by darcy@.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r 9af20de43ffd -r 47dcb4950111 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Sun Jan 06 12:41:11 2008 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Sun Jan 06 14:55:00 2008 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.754 2008/01/06 01:02:14 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.755 2008/01/06 14:55:00 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -4670,7 +4670,9 @@
                                        $line->log_warning("The \"${plain_tool}\" tool is used but not added to USE_TOOLS.");
                                }
 
-                               if (defined($mkctx_target) && $mkctx_target =~ qr"^(?:pre|do|post)-(?:extract|patch|wrapper|configure|build|install|package|clean)$") {
+                               # Deactivated to allow package developers to write
+                               # consistent code that uses ${TOOL} in all places.
+                               if (false && defined($mkctx_target) && $mkctx_target =~ qr"^(?:pre|do|post)-(?:extract|patch|wrapper|configure|build|install|package|clean)$") {
                                        if (!exists(get_required_vartool_varnames()->{$vartool})) {
                                                $opt_warn_extra and $line->log_note("You can write \"${plain_tool}\" instead of \"${shellword}\".");
                                                $opt_warn_extra and $line->explain_note(