pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Added Thomas' explanation for t...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/adf017e45fdc
branches:  trunk
changeset: 538088:adf017e45fdc
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Mon Jan 28 09:25:52 2008 +0000

description:
Added Thomas' explanation for the "PKGREVISION must only be in Makefile"
error message.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diffs (23 lines):

diff -r 1f1fd9ac2a9e -r adf017e45fdc pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Mon Jan 28 05:40:18 2008 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Mon Jan 28 09:25:52 2008 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.759 2008/01/28 01:18:13 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.760 2008/01/28 09:25:52 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -5397,6 +5397,12 @@
                }
                if ($line->fname !~ qr"(?:^|/)Makefile$") {
                        $line->log_error("${varname} must not be set outside the package Makefile.");
+                       $line->explain_error(
+"Usually, different packages using the same Makefile.common have",
+"different dependencies and will be bumped at different times (e.g. for",
+"shlib major bumps) and thus the PKGREVISIONs must be in the separate",
+"Makefiles. There is no practical way of having this information in a",
+"commonly used Makefile.");
                }
 
        } elsif ($type eq "PlatformTriple") {



Home | Main Index | Thread Index | Old Index