[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint pkgtools/pkglint: update to 21.3.3

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/f269a1e4a144
branches:  trunk
changeset: 769371:f269a1e4a144
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sat Nov 13 21:20:59 2021 +0000

description:
pkgtools/pkglint: update to 21.3.3

Changes since 21.3.2:

Explain warning about invalid symlink.

Do not warn when a package uses MAKE_JOBS without adding it to
BUILD_DEFS, since MAKE_JOBS is supposed to be a build-time only
variable.

diffstat:

 pkgtools/pkglint/Makefile         |  5 ++---
 pkgtools/pkglint/files/line.go    |  2 +-
 pkgtools/pkglint/files/package.go |  6 +++++-
 pkgtools/pkglint/files/pkgsrc.go  |  1 +
 4 files changed, 9 insertions(+), 5 deletions(-)

diffs (52 lines):

diff -r fb0fc1abd960 -r f269a1e4a144 pkgtools/pkglint/Makefile
--- a/pkgtools/pkglint/Makefile Sat Nov 13 20:43:51 2021 +0000
+++ b/pkgtools/pkglint/Makefile Sat Nov 13 21:20:59 2021 +0000
@@ -1,7 +1,6 @@
-# $NetBSD: Makefile,v 1.702 2021/11/05 20:02:47 bsiegert Exp $
+# $NetBSD: Makefile,v 1.703 2021/11/13 21:20:59 rillig Exp $
 
-PKGNAME=       pkglint-21.3.2
-PKGREVISION=   1
+PKGNAME=       pkglint-21.3.3
 CATEGORIES=    pkgtools
 DISTNAME=      tools
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=golang/}
diff -r fb0fc1abd960 -r f269a1e4a144 pkgtools/pkglint/files/line.go
--- a/pkgtools/pkglint/files/line.go    Sat Nov 13 20:43:51 2021 +0000
+++ b/pkgtools/pkglint/files/line.go    Sat Nov 13 21:20:59 2021 +0000
@@ -167,7 +167,7 @@
        G.Logger.Diag(line, Note, format, args...)
 }
 
-func (line *Line) Explain(explanation ...string) { G.Logger.Explain(explanation...) }
+func (*Line) Explain(explanation ...string) { G.Logger.Explain(explanation...) }
 
 func (line *Line) String() string {
        return sprintf("%s:%s: %s", line.Filename(), line.Linenos(), line.Text)
diff -r fb0fc1abd960 -r f269a1e4a144 pkgtools/pkglint/files/package.go
--- a/pkgtools/pkglint/files/package.go Sat Nov 13 20:43:51 2021 +0000
+++ b/pkgtools/pkglint/files/package.go Sat Nov 13 21:20:59 2021 +0000
@@ -1494,7 +1494,11 @@
                }
 
        case mode&os.ModeSymlink != 0:
-               NewLineWhole(dirent).Warnf("Invalid symlink name.")
+               line := NewLineWhole(dirent)
+               line.Warnf("Invalid symlink name.")
+               line.Explain(
+                       "The only symlinks that pkglint ever expects are those to",
+                       "WRKDIR, which are usually named 'work' or 'work.*'.")
 
        default:
                NewLineWhole(dirent).Errorf("Only files and directories are allowed in pkgsrc.")
diff -r fb0fc1abd960 -r f269a1e4a144 pkgtools/pkglint/files/pkgsrc.go
--- a/pkgtools/pkglint/files/pkgsrc.go  Sat Nov 13 20:43:51 2021 +0000
+++ b/pkgtools/pkglint/files/pkgsrc.go  Sat Nov 13 21:20:59 2021 +0000
@@ -881,6 +881,7 @@
                "FETCH_CMD",
                "FETCH_OUTPUT_ARGS",
                "FETCH_USING",
+               "MAKE_JOBS",
                "PKGSRC_RUN_TEST")
 
        // The following variables are used so often that not every