[pkgsrc/trunk]: pkgsrc/net/freeradius freeradius: correct config installation...

[gutteridge <gutteridge%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/55353de8a13f
branches:  trunk
changeset: 382075:55353de8a13f
user:      gutteridge <gutteridge%pkgsrc.org@localhost>
date:      Wed Jul 20 01:19:55 2022 +0000

description:
freeradius: correct config installation and de-installation

The script that un-installs the configuration content placed under the
PKG_SYSCONFDIR wasn't removing one of the files that's installed. (This
had been incorrect since it was added to the installation script back
in 2017.)

Separately, simplify the previous changes I made to fix installation of
configuration files to PKG_SYSCONFDIR. I had used redundancy to force
certain directories necessary for startup to be present and populated,
but the pre-existing code in the scripts had almost all of it covered,
just not the creation of the directories themselves and a single file.

diffstat:

 net/freeradius/DEINSTALL |   7 ++++---
 net/freeradius/INSTALL   |   4 ++--
 net/freeradius/Makefile  |   4 ++--
 net/freeradius/config.mk |  41 ++++++-----------------------------------
 4 files changed, 14 insertions(+), 42 deletions(-)

diffs (125 lines):

diff -r 5df95cb9e727 -r 55353de8a13f net/freeradius/DEINSTALL
--- a/net/freeradius/DEINSTALL  Tue Jul 19 23:05:55 2022 +0000
+++ b/net/freeradius/DEINSTALL  Wed Jul 20 01:19:55 2022 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: DEINSTALL,v 1.3 2019/12/30 18:17:22 adam Exp $
+# $NetBSD: DEINSTALL,v 1.4 2022/07/20 01:19:55 gutteridge Exp $
 #
 # Remove default symlinks in ${PKG_SYSCONFDIR} for enabled modules/sites
 #
@@ -7,7 +7,7 @@
 MODS_ENABLED="always attr_filter cache_eap chap date detail detail.log
              digest dynamic_clients eap echo exec expiration expr
              files linelog logintime mschap ntlm_auth pap passwd preprocess
-             radutmp realm replicate soh sradutmp unix unpack utf8"
+             radutmp realm replicate soh sradutmp totp unix unpack utf8"
 
 case ${STAGE} in
 DEINSTALL)
@@ -19,8 +19,9 @@
            ${RM} -f @PKG_SYSCONFDIR@/mods-enabled/${m}
        done
        ${RMDIR} @PKG_SYSCONFDIR@/sites-enabled
-       ${RMDIR} @PKG_SYSCONFDIR@/mods-enabled  
+       ${RMDIR} @PKG_SYSCONFDIR@/mods-enabled
        ${RM} @PKG_SYSCONFDIR@/hints
        ${RM} @PKG_SYSCONFDIR@/huntgroups
+       ${RM} @PKG_SYSCONFDIR@/users
        ;;
 esac
diff -r 5df95cb9e727 -r 55353de8a13f net/freeradius/INSTALL
--- a/net/freeradius/INSTALL    Tue Jul 19 23:05:55 2022 +0000
+++ b/net/freeradius/INSTALL    Wed Jul 20 01:19:55 2022 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: INSTALL,v 1.2 2018/04/12 01:21:07 nonaka Exp $
+# $NetBSD: INSTALL,v 1.3 2022/07/20 01:19:55 gutteridge Exp $
 #
 # Create default symlinks in ${PKG_SYSCONFDIR} for enabled modules/sites
 #
@@ -7,7 +7,7 @@
 MODS_ENABLED="always attr_filter cache_eap chap date detail detail.log
              digest dynamic_clients eap echo exec expiration expr
              files linelog logintime mschap ntlm_auth pap passwd preprocess
-             radutmp realm replicate soh sradutmp unix unpack utf8"
+             radutmp realm replicate soh sradutmp totp unix unpack utf8"
 
 case ${STAGE} in
 POST-INSTALL)
diff -r 5df95cb9e727 -r 55353de8a13f net/freeradius/Makefile
--- a/net/freeradius/Makefile   Tue Jul 19 23:05:55 2022 +0000
+++ b/net/freeradius/Makefile   Wed Jul 20 01:19:55 2022 +0000
@@ -1,9 +1,9 @@
-# $NetBSD: Makefile,v 1.115 2022/06/28 11:34:59 wiz Exp $
+# $NetBSD: Makefile,v 1.116 2022/07/20 01:19:55 gutteridge Exp $
 
 .include "Makefile.common"
 
 PKGNAME=       ${DISTNAME:S/-server//}
-PKGREVISION=   2
+PKGREVISION=   3
 COMMENT=       Free RADIUS server implementation
 
 BUILD_DEFS+=           VARBASE
diff -r 5df95cb9e727 -r 55353de8a13f net/freeradius/config.mk
--- a/net/freeradius/config.mk  Tue Jul 19 23:05:55 2022 +0000
+++ b/net/freeradius/config.mk  Wed Jul 20 01:19:55 2022 +0000
@@ -1,6 +1,10 @@
-# $NetBSD: config.mk,v 1.4 2022/04/12 01:02:47 gutteridge Exp $
+# $NetBSD: config.mk,v 1.5 2022/07/20 01:19:55 gutteridge Exp $
 
-# cd ${DESTDIR}${EGDIR}/raddb; find . -type f -or -type l | sort | sed 's,^./,EGFILES+=\t,'
+# cd ${DESTDIR}${EGDIR}/raddb; find . -type f | sort | sed 's,^./,EGFILES+=\t,'
+#
+# Separately, any symlinks intended to be placed in the mods-enabled or
+# sites-enabled directories must be added to the respective variables in the
+# INSTALL and DEINSTALL scripts.
 EGFILES+=      README.rst
 EGFILES+=      certs/Makefile
 EGFILES+=      certs/README.md
@@ -195,37 +199,6 @@
 EGFILES+=      mods-config/sql/moonshot-targeted-ids/sqlite/queries.conf
 EGFILES+=      mods-config/sql/moonshot-targeted-ids/sqlite/schema.sql
 EGFILES+=      mods-config/unbound/default.conf
-EGFILES+=      mods-enabled/always
-EGFILES+=      mods-enabled/attr_filter
-EGFILES+=      mods-enabled/cache_eap
-EGFILES+=      mods-enabled/chap
-EGFILES+=      mods-enabled/date
-EGFILES+=      mods-enabled/detail
-EGFILES+=      mods-enabled/detail.log
-EGFILES+=      mods-enabled/digest
-EGFILES+=      mods-enabled/dynamic_clients
-EGFILES+=      mods-enabled/eap
-EGFILES+=      mods-enabled/echo
-EGFILES+=      mods-enabled/exec
-EGFILES+=      mods-enabled/expiration
-EGFILES+=      mods-enabled/expr
-EGFILES+=      mods-enabled/files
-EGFILES+=      mods-enabled/linelog
-EGFILES+=      mods-enabled/logintime
-EGFILES+=      mods-enabled/mschap
-EGFILES+=      mods-enabled/ntlm_auth
-EGFILES+=      mods-enabled/pap
-EGFILES+=      mods-enabled/passwd
-EGFILES+=      mods-enabled/preprocess
-EGFILES+=      mods-enabled/radutmp
-EGFILES+=      mods-enabled/realm
-EGFILES+=      mods-enabled/replicate
-EGFILES+=      mods-enabled/soh
-EGFILES+=      mods-enabled/sradutmp
-EGFILES+=      mods-enabled/totp
-EGFILES+=      mods-enabled/unix
-EGFILES+=      mods-enabled/unpack
-EGFILES+=      mods-enabled/utf8
 EGFILES+=      panic.gdb
 EGFILES+=      policy.d/abfab-tr
 EGFILES+=      policy.d/accounting
@@ -269,8 +242,6 @@
 EGFILES+=      sites-available/totp
 EGFILES+=      sites-available/virtual.example.com
 EGFILES+=      sites-available/vmps
-EGFILES+=      sites-enabled/default
-EGFILES+=      sites-enabled/inner-tunnel
 EGFILES+=      templates.conf
 EGFILES+=      trigger.conf