[pkgsrc/trunk]: pkgsrc/x11/mlterm mlterm: force consistent builds with posix_...

[gutteridge <gutteridge%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/dd899bef9005
branches:  trunk
changeset: 385026:dd899bef9005
user:      gutteridge <gutteridge%pkgsrc.org@localhost>
date:      Sat Sep 10 00:14:19 2022 +0000

description:
mlterm: force consistent builds with posix_openpt(3) on NetBSD

Work around the fact this package tests whether posix_openpt(3) works at
runtime. This fails in typical sandboxed build environments (including
TNF's used for official binary builds), which causes a fallback to use
"old-style" BSD ptys, which can result in runtime failures.

Addresses PR pkg/56936. Needs monitoring to ensure official TNF binary
packages now behave as expected.

diffstat:

 x11/mlterm/Makefile |  16 +++++++++++++---
 1 files changed, 13 insertions(+), 3 deletions(-)

diffs (35 lines):

diff -r d5928eae7515 -r dd899bef9005 x11/mlterm/Makefile
--- a/x11/mlterm/Makefile       Fri Sep 09 22:50:35 2022 +0000
+++ b/x11/mlterm/Makefile       Sat Sep 10 00:14:19 2022 +0000
@@ -1,11 +1,11 @@
-# $NetBSD: Makefile,v 1.175 2022/08/11 05:09:31 gutteridge Exp $
+# $NetBSD: Makefile,v 1.176 2022/09/10 00:14:19 gutteridge Exp $
 
 DISTNAME=      mlterm-3.9.2
 DIST_SUBDIR=   ${PKGNAME_NOREV}        # for re-tagged 3.9.2
-PKGREVISION=   5
+PKGREVISION=   6
 CATEGORIES=    x11
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=arakiken/}
-GITHUB_PROJECT= ${PKGBASE}
+GITHUB_PROJECT=        ${PKGBASE}
 GITHUB_TAG=    ${PKGVERSION_NOREV}
 
 MAINTAINER=    tsutsui%NetBSD.org@localhost
@@ -35,6 +35,16 @@
 .include "../../mk/bsd.prefs.mk"
 .include "options.mk"
 
+# Work around the fact this package tests whether posix_openpt(3) works at
+# runtime. This fails in typical sandboxed build environments (including
+# TNF's used for official binary builds), which causes a fallback to use
+# "old-style" BSD ptys. (If a user was running a kernel with non-standard
+# settings that don't support the expectations here, they'd need to disable
+# this override.) See PR pkg/56936.
+.if ${OPSYS} == "NetBSD"
+CONFIGURE_ENV+=                bl_cv_pty=streams
+.endif
+
 SUBST_CLASSES+=                link
 SUBST_MESSAGE.link=    Fixing hardcoded paths and link options in Makefiles.
 SUBST_STAGE.link=      pre-configure