[pkgsrc/trunk]: pkgsrc/net/rsync rsync: updated to 3.2.7

[adam <adam%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/be77babea660
branches:  trunk
changeset: 387164:be77babea660
user:      adam <adam%pkgsrc.org@localhost>
date:      Mon Oct 24 10:28:22 2022 +0000

description:
rsync: updated to 3.2.7

rsync 3.2.7 (20 Oct 2022)

BUG FIXES:

- Fixed the client-side validating of the remote sender's filtering behavior.

- More fixes for the "unrequested file-list name" name, including a copy of
  "/" with `--relative` enabled and a copy with a lot of related paths with
  `--relative` enabled (often derived from a `--files-from` list).

- When rsync gets an unpack error on an ACL, mention the filename.

- Avoid over-setting sanitize_paths when a daemon is serving "/" (even if
  "use chroot" is false).

ENHANCEMENTS:

- Added negotiated daemon-auth support that allows a stronger checksum digest
  to be used to validate a user's login to the daemon.  Added SHA512, SHA256,
  and SHA1 digests to MD5 & MD4.  These new digests are at the highest priority
  in the new daemon-auth negotiation list.

- Added support for the SHA1 digest in file checksums.  While this tends to be
  overkill, it is available if someone really needs it.  This overly-long
  checksum is at the lowest priority in the normal checksum negotiation list.
  See [`--checksum-choice`](rsync.1#opt) (`--cc`) and the `RSYNC_CHECKSUM_LIST`
  environment var for how to customize this.

- Improved the xattr hash table to use a 64-bit key without slowing down the
  key's computation.  This should make extra sure that a hash collision doesn't
  happen.

- If the `--version` option is repeated (e.g. `-VV`) then the information is
  output in a (still readable) JSON format.  Client side only.

- The script `support/json-rsync-version` is available to get the JSON style
  version output from any rsync.  The script accepts either text on stdin
  **or** an arg that specifies an rsync executable to run with a doubled
  `--version` option.  If the text we get isn't already in JSON format, it is
  converted. Newer rsync versions will provide more complete json info than
  older rsync versions. Various tweaks are made to keep the flag names
  consistent across versions.

- The [`use chroot`](rsyncd.conf.5#) daemon parameter now defaults to "unset"
  so that rsync can use chroot when it works and a sanitized copy when chroot
  is not supported (e.g., for a non-root daemon).  Explicitly setting the
  parameter to true or false (on or off) behaves the same way as before.

- The `--fuzzy` option was optimized a bit to try to cut down on the amount of
  computations when considering a big pool of files. The simple heuristic from
  Kenneth Finnegan resuled in about a 2x speedup.

- If rsync is forced to use protocol 29 or before (perhaps due to talking to an
  rsync before 3.0.0), the modify time of a file is limited to 4-bytes.  Rsync
  now interprets this value as an unsigned integer so that a current year past
  2038 can continue to be represented. This does mean that years prior to 1970
  cannot be represented in an older protocol, but this trade-off seems like the
  right choice given that (1) 2038 is very rapidly approaching, and (2) newer
  protocols support a much wider range of old and new dates.

- The rsync client now treats an empty destination arg as an error, just like
  it does for an empty source arg. This doesn't affect a `host:` arg (which is
  treated the same as `host:.`) since the arg is not completely empty.  The use
  of [`--old-args`](rsync.1#opt) (including via `RSYNC_OLD_ARGS`) allows the
  prior behavior of treating an empty destination arg as a ".".

PACKAGING RELATED:

- The checksum code now uses openssl's EVP methods, which gets rid of various
  deprecation warnings and makes it easy to support more digest methods.  On
  newer systems, the MD4 digest is marked as legacy in the openssl code, which
  makes openssl refuse to support it via EVP.  You can choose to ignore this
  and allow rsync's MD4 code to be used for older rsync connections (when
  talking to an rsync prior to 3.0.0) or you can choose to configure rsync to
  tell openssl to enable legacy algorithms (see below).

- A simple openssl config file is supplied that can be installed for rsync to
  use.  If you install packaging/openssl-rsync.cnf to a public spot (such as
  `/etc/ssl/openssl-rsync.cnf`) and then run configure with the option
  `--with-openssl-conf=/path/name.cnf`, this will cause rsync to export the
  configured path in the OPENSSL_CONF environment variable (when the variable
  is not already set).  This will enable openssl's MD4 code for rsync to use.

- The packager may wish to include an explicit "use chroot = true" in the top
  section of their supplied /etc/rsyncd.conf file if the daemon is being
  installed to run as the root user (though rsync should behave the same even
  with the value unset, a little extra paranoia doesn't hurt).

- I've noticed that some packagers haven't installed support/nameconvert for
  users to use in their chrooted rsync configs.  Even if it is not installed
  as an executable script (to avoid a python3 dependency) it would be good to
  install it with the other rsync-related support scripts.

- It would be good to add support/json-rsync-version to the list of installed
  support scripts.

diffstat:

 net/rsync/Makefile |  4 ++--
 net/rsync/distinfo |  8 ++++----
 net/rsync/hacks.mk |  9 ---------
 3 files changed, 6 insertions(+), 15 deletions(-)

diffs (39 lines):

diff -r be48ca30dc77 -r be77babea660 net/rsync/Makefile
--- a/net/rsync/Makefile        Mon Oct 24 09:47:50 2022 +0000
+++ b/net/rsync/Makefile        Mon Oct 24 10:28:22 2022 +0000
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.123 2022/09/11 13:52:40 wiz Exp $
+# $NetBSD: Makefile,v 1.124 2022/10/24 10:28:22 adam Exp $
 
-DISTNAME=      rsync-3.2.6
+DISTNAME=      rsync-3.2.7
 CATEGORIES=    net
 MASTER_SITES=  http://rsync.samba.org/ftp/rsync/
 MASTER_SITES+= http://rsync.samba.org/ftp/rsync/old-versions/
diff -r be48ca30dc77 -r be77babea660 net/rsync/distinfo
--- a/net/rsync/distinfo        Mon Oct 24 09:47:50 2022 +0000
+++ b/net/rsync/distinfo        Mon Oct 24 10:28:22 2022 +0000
@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.57 2022/09/11 13:52:40 wiz Exp $
+$NetBSD: distinfo,v 1.58 2022/10/24 10:28:22 adam Exp $
 
-BLAKE2s (rsync-3.2.6.tar.gz) = f944460bf07d8069d6011e4cbda44ba7649c0bfbe4484a901a79317ecac8df10
-SHA512 (rsync-3.2.6.tar.gz) = d141d04732c91e055708e8d1f14b976f9483208a93076bb66dc75cbf87d54f2dcbffc11423f0c9c005d2d4e20cb9c147a7672f7a9c0b987f4e2c39b4c3645cfe
-Size (rsync-3.2.6.tar.gz) = 1138593 bytes
+BLAKE2s (rsync-3.2.7.tar.gz) = 3f0c5407e9b854f3807b68c4e9935f72dac1dec65da75801d202f44d50fbe91b
+SHA512 (rsync-3.2.7.tar.gz) = c2afba11a352fd88133f9e96e19d6df80eb864450c83eced13a7faa23df947bccf2ef093f2101df6ee30abff4cbbd39ac802e9aa5f726e42c9caff274fad8377
+Size (rsync-3.2.7.tar.gz) = 1149787 bytes
 SHA1 (patch-Makefile.in) = 34c3cc57846e451a0adbd19fcb19ae682b7e1ae3
diff -r be48ca30dc77 -r be77babea660 net/rsync/hacks.mk
--- a/net/rsync/hacks.mk        Mon Oct 24 09:47:50 2022 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,9 +0,0 @@
-# $NetBSD: hacks.mk,v 1.4 2008/03/11 10:16:43 tron Exp $
-
-### [Tue Nov 21 19:32:00 UTC 2006 : tvierling]
-### iconv(..., NULL, 0, NULL, 0) crashes in libc version of iconv(3)
-###
-.if ${OPSYS} == "Interix"
-PKG_HACKS+=    pkgsrc-iconv
-.include "../../converters/libiconv/buildlink3.mk"
-.endif