[pkgsrc/trunk]: pkgsrc/net openvpn: updated to 2.5.8

[adam <adam%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/7bc66a90fa70
branches:  trunk
changeset: 388570:7bc66a90fa70
user:      adam <adam%pkgsrc.org@localhost>
date:      Wed Nov 23 08:02:57 2022 +0000

description:
openvpn: updated to 2.5.8

Overview of changes in 2.5.8

New features

allow running a default configuration with TLS libraries without BF-CBC (even if TLS cipher negotiation would not actually use BF-CBC, the long-term compatibility "default cipher BF-CBC" would 
trigger an error on such TLS libraries)

User-visible Changes

add git branch name + commit ID to OpenVPN version string on MSVC builds (windows)

Testing Enhancements

t_client.sh: if fping is found and fping6 is not, assume we have fping 4.0 and up, and call "fping -6" for IPv6 ping tests
t_client.sh: allow to force FAIL on prerequisite fails, so a CI environment will no longer "silently skip" t_client runs if fping (etc) can not be found, but will error out

Bugfixes

``--auth-nocache'' was not always correctly clearing username+password after a renegotiation
ensure that auth-token received from server is cleared if requested by the management interface ("forget password" or automatically via ``--management-forget-disconnect'')
in a setup without username+password, but with auth-token and auth-token-username pushed by the server, OpenVPN would start asking for username+password on token expiry. Fix.
using --auth-token together with --management-client-auth (on the server) would lead to TLS keys getting out of sync and client being disconnected. Fix.
management interface would sometimes get stuck if client and server try to write something simultaneously. Fix by allowing a limited level of recursion in virtual_output_callback()
fix management interface not returning ERROR:/SUCCESS: response on "signal SIGxxx" commands when in HOLD state
tls-crypt-v2: abort connection if client-key is too short
make man page agree with actual code on replay-window backtrag log message
remove useless empty line from CR_RESPONSE message

diffstat:

 net/openvpn-acct-wtmpx/distinfo     |   8 ++++----
 net/openvpn-nagios/distinfo         |   8 ++++----
 net/openvpn/Makefile                |   3 +--
 net/openvpn/Makefile.common         |   4 ++--
 net/openvpn/distinfo                |   9 ++++-----
 net/openvpn/patches/patch-configure |  14 --------------
 6 files changed, 15 insertions(+), 31 deletions(-)

diffs (92 lines):

diff -r 4aad58fe38c7 -r 7bc66a90fa70 net/openvpn-acct-wtmpx/distinfo
--- a/net/openvpn-acct-wtmpx/distinfo   Wed Nov 23 05:56:53 2022 +0000
+++ b/net/openvpn-acct-wtmpx/distinfo   Wed Nov 23 08:02:57 2022 +0000
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.32 2022/05/31 18:03:41 gdt Exp $
+$NetBSD: distinfo,v 1.33 2022/11/23 08:02:57 adam Exp $
 
-BLAKE2s (openvpn-2.5.7.tar.gz) = d0540c7cc532ccaaadf6ab147b84adadce075d955fbd4d466228fc85c089b440
-SHA512 (openvpn-2.5.7.tar.gz) = b90dc9ddb9c3bc8eda9ffa0507bb82c46347a44fb05861859665ac6f9759345054f47bc86073dcaf06d56b1e403e94d887aa0480e17188075c19c909daf18844
-Size (openvpn-2.5.7.tar.gz) = 1855516 bytes
+BLAKE2s (openvpn-2.5.8.tar.gz) = 7af26d7da32f771a6b34a5c25e4c0ffc6084a776c0c9f5dbd920f05a47810224
+SHA512 (openvpn-2.5.8.tar.gz) = 9cb0e79f26e7021141213d241fffaaa899575fa1640cb02d5f2a7b71f1ae12faac762ac26c2e4ddc4822550aa12cb81bab7a5b259d81230983e9b098e0f14091
+Size (openvpn-2.5.8.tar.gz) = 1875551 bytes
 BLAKE2s (openvpn-acct-wtmpx-20130210.tgz) = 2bb02a4e6adb7ce1d189271a6fbb6cbffd6a37d7b5e75cccebfc8dfac6dbaddd
 SHA512 (openvpn-acct-wtmpx-20130210.tgz) = 7b8fd4929e65d8d84158f62e5a17ff3adb3b4a6cff63b29038acfb368750719f2f593786ed9b02402824c19d872b188d2a46740a5c5f853e8873a71481b13aaf
 Size (openvpn-acct-wtmpx-20130210.tgz) = 2778 bytes
diff -r 4aad58fe38c7 -r 7bc66a90fa70 net/openvpn-nagios/distinfo
--- a/net/openvpn-nagios/distinfo       Wed Nov 23 05:56:53 2022 +0000
+++ b/net/openvpn-nagios/distinfo       Wed Nov 23 08:02:57 2022 +0000
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.29 2022/05/31 18:03:41 gdt Exp $
+$NetBSD: distinfo,v 1.30 2022/11/23 08:02:58 adam Exp $
 
-BLAKE2s (openvpn-2.5.7.tar.gz) = d0540c7cc532ccaaadf6ab147b84adadce075d955fbd4d466228fc85c089b440
-SHA512 (openvpn-2.5.7.tar.gz) = b90dc9ddb9c3bc8eda9ffa0507bb82c46347a44fb05861859665ac6f9759345054f47bc86073dcaf06d56b1e403e94d887aa0480e17188075c19c909daf18844
-Size (openvpn-2.5.7.tar.gz) = 1855516 bytes
+BLAKE2s (openvpn-2.5.8.tar.gz) = 7af26d7da32f771a6b34a5c25e4c0ffc6084a776c0c9f5dbd920f05a47810224
+SHA512 (openvpn-2.5.8.tar.gz) = 9cb0e79f26e7021141213d241fffaaa899575fa1640cb02d5f2a7b71f1ae12faac762ac26c2e4ddc4822550aa12cb81bab7a5b259d81230983e9b098e0f14091
+Size (openvpn-2.5.8.tar.gz) = 1875551 bytes
 BLAKE2s (openvpn-nagios-20130210.tgz) = 713b55e865350c44a314aa3b48694695f4d82b50883d1fae919f01e9545c7c34
 SHA512 (openvpn-nagios-20130210.tgz) = 80e565f32379c39eb6c7f3b4744af221ae882ff07dce9dae5bd7feb73b0edcfc7c7ac7f70d23fdcd4f492b66f095f09833deb122449840b36ea606ce91900358
 Size (openvpn-nagios-20130210.tgz) = 3034 bytes
diff -r 4aad58fe38c7 -r 7bc66a90fa70 net/openvpn/Makefile
--- a/net/openvpn/Makefile      Wed Nov 23 05:56:53 2022 +0000
+++ b/net/openvpn/Makefile      Wed Nov 23 08:02:57 2022 +0000
@@ -1,7 +1,6 @@
-# $NetBSD: Makefile,v 1.94 2022/10/26 10:31:50 wiz Exp $
+# $NetBSD: Makefile,v 1.95 2022/11/23 08:02:57 adam Exp $
 
 DISTNAME=      ${OPENVPN_DISTNAME}
-PKGREVISION=   2
 CATEGORIES=    net
 MASTER_SITES=  ${OPENVPN_MASTER_SITES}
 
diff -r 4aad58fe38c7 -r 7bc66a90fa70 net/openvpn/Makefile.common
--- a/net/openvpn/Makefile.common       Wed Nov 23 05:56:53 2022 +0000
+++ b/net/openvpn/Makefile.common       Wed Nov 23 08:02:57 2022 +0000
@@ -1,9 +1,9 @@
-# $NetBSD: Makefile.common,v 1.26 2022/05/31 18:03:41 gdt Exp $
+# $NetBSD: Makefile.common,v 1.27 2022/11/23 08:02:57 adam Exp $
 # used by net/openvpn/Makefile
 # used by net/openvpn-acct-wtmpx/Makefile
 # used by net/openvpn-nagios/Makefile
 
-OPENVPN_DISTNAME=              openvpn-2.5.7
+OPENVPN_DISTNAME=              openvpn-2.5.8
 OPENVPN_DISTFILE=              ${OPENVPN_DISTNAME}.tar.gz
 OPENVPN_MASTER_SITES=          https://swupdate.openvpn.org/community/releases/
 SITES.${OPENVPN_DISTFILE}=     ${OPENVPN_MASTER_SITES}
diff -r 4aad58fe38c7 -r 7bc66a90fa70 net/openvpn/distinfo
--- a/net/openvpn/distinfo      Wed Nov 23 05:56:53 2022 +0000
+++ b/net/openvpn/distinfo      Wed Nov 23 08:02:57 2022 +0000
@@ -1,7 +1,6 @@
-$NetBSD: distinfo,v 1.57 2022/05/31 18:03:41 gdt Exp $
+$NetBSD: distinfo,v 1.58 2022/11/23 08:02:57 adam Exp $
 
-BLAKE2s (openvpn-2.5.7.tar.gz) = d0540c7cc532ccaaadf6ab147b84adadce075d955fbd4d466228fc85c089b440
-SHA512 (openvpn-2.5.7.tar.gz) = b90dc9ddb9c3bc8eda9ffa0507bb82c46347a44fb05861859665ac6f9759345054f47bc86073dcaf06d56b1e403e94d887aa0480e17188075c19c909daf18844
-Size (openvpn-2.5.7.tar.gz) = 1855516 bytes
-SHA1 (patch-configure) = ad37ce26c1596699b6534c5f0077490abb55160b
+BLAKE2s (openvpn-2.5.8.tar.gz) = 7af26d7da32f771a6b34a5c25e4c0ffc6084a776c0c9f5dbd920f05a47810224
+SHA512 (openvpn-2.5.8.tar.gz) = 9cb0e79f26e7021141213d241fffaaa899575fa1640cb02d5f2a7b71f1ae12faac762ac26c2e4ddc4822550aa12cb81bab7a5b259d81230983e9b098e0f14091
+Size (openvpn-2.5.8.tar.gz) = 1875551 bytes
 SHA1 (patch-src_compat_compat-basename.c) = 45a58ef2e05f6e0265f229da8540760e60e65143
diff -r 4aad58fe38c7 -r 7bc66a90fa70 net/openvpn/patches/patch-configure
--- a/net/openvpn/patches/patch-configure       Wed Nov 23 05:56:53 2022 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,14 +0,0 @@
-$NetBSD: patch-configure,v 1.3 2022/03/17 07:50:17 adam Exp $
-
-Support net/if_tap.h
-
---- configure.orig     2022-03-16 12:16:26.000000000 +0000
-+++ configure
-@@ -15081,6 +15081,7 @@ for ac_header in  \
-       sys/mman.h sys/file.h sys/wait.h \
-       unistd.h signal.h libgen.h stropts.h \
-       syslog.h pwd.h grp.h \
-+      net/if_tap.h \
-       sys/sockio.h sys/uio.h linux/sockios.h \
-       linux/types.h linux/errqueue.h poll.h sys/epoll.h err.h \
-