Re: CVS commit: pkgsrc/chat/pidgin

["Julio M. Merino Vidal" <jmmv84%gmail.com@localhost>]

On Tue, Apr 29, 2008 at 2:44 PM, Tobias Nygren <tnn%netbsd.org@localhost> wrote:
> On Tue, 29 Apr 2008 12:35:10 +0000 (UTC)
>  "Julio M. Merino Vidal" <jmmv%netbsd.org@localhost> wrote:
>
>  >
>  > Module Name:  pkgsrc
>  > Committed By: jmmv
>  > Date:         Tue Apr 29 12:35:10 UTC 2008
>  >
>  > Modified Files:
>  >       pkgsrc/chat/pidgin: Makefile PLIST options.mk
>  >
>  > Log Message:
>  > Fix build when dbus is installed
>  >
>  > Add an option to select whether dbus support should be enabled or not and
>  > use it to control the installation of the musicmessaging plugin.  Fixes the
>  > package when dbus is already installed.  Bump PKGREVISION to 2.
>  >
>  > Ew.  Conditional builds.
>
>  I'm not sure this one is correct. I think it should use
>  pkg-build-options to determine whether or not "libpurple" was built
>  with dbus support and use that to enable/disable.
>
>  libpurple's bl3.mk has the dbus includes if it was built with dbus.

pidgin is still checking on its own if dbus is available or not, and
it has its own --enable-pidgin flag.  It may be possible that pidgin
and libpurple are using dbus for different things and needn't be built
consistently; or maybe they need...  Build-time options are a can of
worms.

-- 
Julio M. Merino Vidal <jmmv84%gmail.com@localhost>