Re: CVS commit: pkgsrc/devel/generate

["D'Arcy J.M. Cain" <darcy%NetBSD.org@localhost>]

On Tue, 20 May 2008 22:12:55 +0300
Aleksey Cheusov <cheusov%tut.by@localhost> wrote:
> > On Tue, May 20, 2008 at 06:53:16PM +0000, D'Arcy J.M. Cain wrote:
>  >> Log Message:
>  >> Update to 2.5.
>  >> Uses internal version of strdup (my_strdup) rather than depending on
>  >> availability in all systems.  Fixes Linux bulk build.
> 
> > Are you sure this isn't some random _POSIX_SOURCE or so?
> > On the other hand, glibc...
> 
> STRDUP(3)            Linux Programmer's Manual                 STRDUP(3)
> 
> NAME
>        strdup, strndup, strdupa, strndupa - duplicate a string
> 
> SYNOPSIS
>        #include <string.h>
> 
>        char *strdup(const char *s);
> ...
> 
> -- 
> Best regards, Aleksey Cheusov.

I don't run Linux so all I can go by is the Linux 2.6.24-1-686/i686
bulk build results:

===> Building for generate-2.4
gcc -O2 -ansi -pipe -Wall -Wshadow -Wpointer-arith -Wwrite-strings 
-Wstrict-prototypes -Wformat -Wmissing-prototypes -funsigned-char 
-I/usr/local/include -L/usr/local/lib -Dscanf=DONT_USE_SCANF 
-Dgets=DONT_USE_GETS -Werror -DVERSION_MAJOR=2 -DVERSION_MINOR=4 
-DXGETLINE_VERSION   -c -o generate.o generate.c
cc1: warnings being treated as errors
generate.c: In function 'init_macros':
generate.c:200: warning: implicit declaration of function 'strdup'

Anyway, as I said, it's a bit more robust the way I did it.

-- 
D'Arcy J.M. Cain <darcy%NetBSD.org@localhost>
http://www.NetBSD.org/