Re: CVS commit: pkgsrc/sysutils

[Paul Goyette <paul%whooppee.com@localhost>]

Oh, joy!  My first "why did you do that?"  :)

On Tue, 29 Jul 2008, Joerg Sonnenberger wrote:

> On Tue, Jul 29, 2008 at 05:21:39PM +0000, Paul Goyette wrote:
> > Log Message:
> > Disable IPv6 by default, since this doesn't work on systems which are
> > configured for IPv4 only.  IPv6 can still be enabled via PKG_OPTIONS.
>
> I don't think this is the correct approach.

This approach was taken after extensive discussions with Greg Troxell.

The ultimate fix is to separate amanda's socket-I/O to use separate 
sockets for IPv4 and v6.  But that's a much longer-term solution, and 
one that I'm probably not qualified to undertake, at least not yet.

> First of all, there is an option for ipv6 support and it should be used.

That's exactly what this patch does.  It makes amanda's ./configure 
depend on the presence or absence of the inet6 package option.

> Second, why is it in Makefile.common unconditonal?

It's not unconditional.  It defaults to off, but can easily be turned 
back on by specifying PKG_OPTIONS.amanda=inet6.  I'd be happy to make 
the default depend on whether the build environment has IPv6 support, 
but I'm not sure that's the right approach, as it would prevent future 
cross-building of packages.

If you've got an alternate approach to this, please let me know.  I'd be 
happy to take a different path.


----------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul%whooppee.com@localhost   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette%juniper.net@localhost |
----------------------------------------------------------------------