Re: CVS commit: pkgsrc/emulators/suse113_linux

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

On Tue, Nov 02, 2010 at 09:26:45AM -0700, Chuck Silvers wrote:
> On Mon, Nov 01, 2010 at 04:15:29PM +0100, Bernd Ernesti wrote:
> > Hmm,
> > 
> > # The SuSE 11.x Linux packages are only usable on the following platforms.
> > .if defined(SUSE_COMPAT32)
> > .else
> > EMUL_PLATFORMS+=        linux-x86_64
> > ONLY_FOR_PLATFORM+=     NetBSD-5.99*-i386
> > ONLY_FOR_PLATFORM+=     NetBSD-[6-9]*-i386
> > .endif
> > EMUL_PLATFORMS+=        linux-i386
> > ONLY_FOR_PLATFORM+=     NetBSD-5.99*-x86_64
> > ONLY_FOR_PLATFORM+=     NetBSD-[6-9]*-x86_64
> > 
> > looks strange.
> > 
> > The .else and .endif should maybe in different lines.
> > 
> > Bernd
> 
> hi bernd,
> 
> I admit it does look weird, but I think the effect is right.
> the SUSE_COMPAT32 packages are available only on x86_64 and emulate i386.
> the non-SUSE_COMPAT32 packages are available on both i386 and x86_64
> and emulate the corresponding linux platform.  I just pulled
> the common entries out of the conditional.  I could put them back into
> the conditional (like suse100_linux has them) if that would be clearer.

What about the following:

.if !defined(SUSE_COMPAT32)
EMUL_PLATFORMS+=        linux-x86_64
ONLY_FOR_PLATFORM+=     NetBSD-5.99*-i386
ONLY_FOR_PLATFORM+=     NetBSD-[6-9]*-i386
.endif
EMUL_PLATFORMS+=        linux-i386
ONLY_FOR_PLATFORM+=     NetBSD-5.99*-x86_64
ONLY_FOR_PLATFORM+=     NetBSD-[6-9]*-x86_64

And a comment describing why it is done this way?
I haven't tried to check out how SUSE_COMPAT32 works but that should have the 
same
effect.

Bernd