CVS commit: pkgsrc/pkgtools/pkg_rolling-replace

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Mon Dec 20 15:24:25 UTC 2010

Modified Files:
        pkgsrc/pkgtools/pkg_rolling-replace: Makefile
        pkgsrc/pkgtools/pkg_rolling-replace/files: pkg_rolling-replace.sh

Log Message:
0.22: Avoid infinite loop in some error cases.

Sometimes, the set of packages to be replaced ($REPLACE_TODO) does not
have any members which are installed (and hence in $TSORTED).  This
caused the loop over $TSORTED to not find any packages to replace.
The check for not having found one was missing, resulting in the last
package in TSORTED being replaced.  Because $REPLACE_TODO is still
non-empty, this repeats.

This patch adds an abort when no packages in $TSORTED are in
$REPLACE_TODO.  Analysis and patch from Ian D. Leroux on
pkgsrc-users@.


To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 pkgsrc/pkgtools/pkg_rolling-replace/Makefile
cvs rdiff -u -r1.28 -r1.29 \
    pkgsrc/pkgtools/pkg_rolling-replace/files/pkg_rolling-replace.sh

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.