Re: CVS commit: pkgsrc/pkgtools/pkg_rolling-replace

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Fri, Dec 24, 2010 at 10:37:19PM +0900, OBATA Akio wrote:
> On Fri, 24 Dec 2010 21:58:10 +0900, Greg Troxel <gdt%ir.bbn.com@localhost> 
> wrote:
> 
> >
> >"OBATA Akio" <obache%netbsd.org@localhost> writes:
> >
> >>On Tue, 21 Dec 2010 00:39:09 +0900, Greg Troxel <gdt%netbsd.org@localhost> 
> >>wrote:
> >>
> >>>Module Name:       pkgsrc
> >>>Committed By:      gdt
> >>>Date:              Mon Dec 20 15:39:09 UTC 2010
> >>>
> >>>Log Message:
> >>>0.23: Pass PKGNAME_REQD to make operations.
> >>>
> >>>Set PKGNAME_REQD to give underlying make processes a chance to set
> >>>options derived from the package name.  For example, the appropriate
> >>>version of Python can be derived from the package name (so, when
> >>>building py25-foo, use python-2.5, not python-2.6).   Specifically,
> >>>  MAKE_SET_VARS='PKGNAME_REQD=${pkg}-*'
> >>>
> >>>From Alan Barret via pkgsrc-users@.
> >
> >>If DEPENDS_TARGET=bin-install, installation of dependencies will fail.
> >
> >Is that a bug in pkg_rr, or in the underlying make targets?
> >
> >Have you seen this happen, and do you have a trace?
> 
> You can reproduce anywhere with "make PKGNAME_REQD='pkg-*' replace"
> if it have new dependency, or some of BUILD_DEPENDS are not installed.
> If PKGNAME_REQD is passed as environment variable, it will not happen.
> 
> I cannot judge that it is a bug, because there are no spec.
> If you change targets as pkg_rolling-replace likes, somewhere else
> may not works as before.

Specifying a variable on the command line makes it next to impossible to
override. That should be avoided if at all possible.

Joerg