Re: CVS commit: pkgsrc/games/xmris

["OBATA Akio" <obache%netbsd.org@localhost>]

On Wed, 25 May 2011 13:27:01 +0900, OBATA Akio <obache%netbsd.org@localhost> 
wrote:

> On Wed, 25 May 2011 13:11:43 +0900, David Holland 
> <dholland-pkgchanges%netbsd.org@localhost> wrote:
>
> > On Mon, May 23, 2011 at 12:05:54PM +0000, OBATA Akio wrote:
> >  > Modified Files:
> >  >   pkgsrc/games/xmris: Makefile distinfo
> >  >   pkgsrc/games/xmris/patches: patch-aa
> >  > Removed Files:
> >  >   pkgsrc/games/xmris: DEINSTALL
> >  >
> >  > Log Message:
> >  > * add user-destdir installation support.
> >  > * set LICENSE=gnu-gpl-v2
> >  > * replace manual SED with SUBST.
> >  > * prepare game score directory and file with pkgsrc.
> >
> > I think you forgot USE_GAMESGROUP=yes...
>
> I feel that USE_GAMESGROUP is user settable variable, not packages
> because it is in mk/defaults/mk.conf.
>
> or mark pkg as BROKEN (or not use special perms) if USE_GAMESGROUP=no?

It's nice that ERROR will be risen by pkglint(1) if GAME* variables is used in 
the package,
but USE_GAMESGROUP=yes is not defined (and not WARN if it is defined ...).

--
OBATA Akio / obache%NetBSD.org@localhost