Re: CVS commit: pkgsrc/multimedia/xvidcore

[Matthias Scheler <tron%netbsd.org@localhost>]

On Fri, Jun 24, 2011 at 09:44:59PM +0900, OBATA Akio wrote:
> >>>Module Name:       pkgsrc
> >>>Committed By:      tron
> >>>Date:              Fri Jun 24 09:03:32 UTC 2011
> >>>
> >>>Modified Files:
> >>>   pkgsrc/multimedia/xvidcore: Makefile distinfo
> >>>   pkgsrc/multimedia/xvidcore/patches: patch-ac
> >>>
> >>>Log Message:
> >>>Make this build with GNU patch 2.5.8 by avoiding patch files with ".."
> >>>in the filename.
> >>>
> >>>XXX We need a generic solution for this.
> >>
> >>For this case, it is invalid usage of WRKSRC:
> >>
> >>WRKSRC=         ${WRKDIR}/xvidcore/build/generic
> >>
> >>It should be followings instead:
> >>
> >>WRKSRC=             ${WRKDIR}/xvidcore
> >>CONFIGURE_DIRS=     build/generic
> >
> >But that wouldn't fix the build stage, would it?
> 
> In mk/build/bsd.build-vars.mk:
> BUILD_DIRS?= ${CONFIGURE_DIRS}

Ah, I see. Thanks a lot for the explanation.

> Additionally, pkgsrc *_CHECK and *_OVERRIDE stuffs for source codes will
> only effect to files in ${WRKSRC}, i.e. ${WRKSRC} must point to top directory
> of source tree.

Good point. I'll fix the package as suggested by you.

        Kind regards

-- 
Matthias Scheler                                  http://zhadum.org.uk/