Re: CVS commit: pkgsrc/multimedia/vlc

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sat, Nov 12, 2011 at 01:40:55AM +0100, John Marino wrote:
> On 11/12/2011 12:32 AM, Joerg Sonnenberger wrote:
> >Module Name: pkgsrc
> >Committed By:        joerg
> >Date:                Fri Nov 11 23:32:39 UTC 2011
> >
> >Modified Files:
> >     pkgsrc/multimedia/vlc: PLIST
> >
> >Log Message:
> >Revert. No revbump, unconditional adding of files that are highly
> >platform specific, adding files that don't belong into a PLIST.
> >
> >
> >To generate a diff of this commit:
> >cvs rdiff -u -r1.45 -r1.46 pkgsrc/multimedia/vlc/PLIST
> >
> >Please note that diffs are not public domain; they are subject to the
> >copyright notices on the relevant files.
> >
> 
> If the *.a and *.so are garbage, but *.la files aren't, why were the
> *.la files removed as well?

vlc packages fine without the PLIST change e.g. on NetBSD-5.99.56/amd64.

>From the names, I guess they were installed because vlc configure
found some additional dependencies on your setup. If that's the case,
they should either be made optional or necessary dependencies and the
PLIST modified accordingly; and configure given the necessary
arguments to disable them if the option is turned off, in case they
are optional.

If the above (dependencies) is not the case, then the additional .la
files are specific to the operating system and need to be added in a
separate PLIST.${OPSYS} file instead.

Either way, when modifying the PLIST, the PKGREVISION always needs to
be bumped.
 Thomas