Re: CVS commit: pkgsrc/multimedia/vlc

[John Marino <marino%netbsd.org@localhost>]

On 11/12/2011 2:15 AM, Joerg Sonnenberger wrote:
> On Sat, Nov 12, 2011 at 02:01:57AM +0100, Alistair Crooks wrote:
> > So please do NOT make changes based on the tinderbox "findings";
> > rather, I'd much prefer it if you set PKG_DEVELOPER=yes (which, as wiz
> > points out) does most of the work that tinderbox does, but for all
> > of the pkgsrc platforms as a whole.
> To go a bit more into detail here, PKG_DEVELOPER includes:
>
> - Missing files in $PREFIX
> - Additional files in $PREFIX, unless explicitly marked so
> - Missing shared library dependencies
> - Missing interpreters in #! lines
> - References to the $WRKDIR with different levels, relatively relaxed by
> default
> - Checks for sane permissions (e.g. no world writeable files and
> direcotries)

As I said in the other email, Tinderbox now handles PKG_DEVELOPER=yes if 
it's set in the more_mk.conf configure.  So it gets all this too.

> There is a reason why the tinderbox port wasn't received with standing
> ovations. What it is providing over the existing infrastructure is quite
> small.
I need to know.  Have you actually used Tinderbox extensively?  Or is 
your assessment based on what you think it does?

Thanks for the elaboration on the PKG_DEVELOPER checks.  It is a useful 
feature.  I had to modify tinderbox to handle the checkperms package 
that gets sucked in though.
John