Re: CVS commit: pkgsrc/x11/xf86-video-intel

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

Hi,

On Tue, Nov 15, 2011 at 08:44:58PM +0000, Jonathan A. Kollasch wrote:
> Module Name:  pkgsrc
> Committed By: jakllsch
> Date:         Tue Nov 15 20:44:58 UTC 2011
> 
> Modified Files:
>       pkgsrc/x11/xf86-video-intel: Makefile distinfo
> Added Files:
>       pkgsrc/x11/xf86-video-intel/patches: patch-src_i830__quirks.c
> 
> Log Message:
> Add DMI support on NetBSD.

[..]
  #ifdef __NetBSD__
  /* NetBSD 6.0+ stores DMI data in sysctl machdep.dmi.* */
[..]

That's not what should be done if the code depends on a specific
version.

There needs to be an addtional check for __NetBSD_Version__ in this
function but unfortunately you can not use 599005600 because this
feature was just added and so this is not the correct version.
5.99.56 is from the end of September.

Either you have to wait until someone bumps the kernel version
to 5.99.57 or you have to do it.
Where I'm not sure if it is such a good idea to bump the kernel
version for such a change.

Bernd