Re: CVS commit: pkgsrc/mail

["OBATA Akio" <obache%netbsd.org@localhost>]

On Thu, 08 Dec 2011 17:15:46 +0900, Steven Drake <sbd%netbsd.org@localhost> 
wrote:

> On Thu, 8 Dec 2011, OBATA Akio wrote:
>
> > On Thu, 08 Dec 2011 05:39:19 +0900, Steven Drake <sbd%netbsd.org@localhost> 
> > wrote:
> >
> > > Module Name:       pkgsrc
> > > Committed By:      sbd
> > > Date:              Wed Dec  7 20:39:19 UTC 2011
> > >
> > > Modified Files:
> > >    pkgsrc/mail/cyrus-imapd: Makefile
> > >    pkgsrc/mail/cyrus-imapd23: Makefile
> > >    pkgsrc/mail/cyrus-imapd24: Makefile
> > >
> > > Log Message:
> > > If a package Makefile is going to try and detect a builtin libraray it
> > > should honor the PREFER* variables.
> >
> > It is trying to use com_err from krb5, so I feel it should be
> > switched with PREFER.${KRB5_TYPE} instead of PREFER.com_err
> > (I cannot find com_err package in pkgsrc).
>
> Thats right there is no com_err package in pkgsrc (there is in pkgsrc-wip),
> other wise I would have added buildlink to it and made sue it had a builtin.
>
> The reason I used PREFER.com_err is because on Linux its not finding com_err
> from krb5 its finding the com_err that is part of e2fsprogs.

Then, what will be happened? com_err from e2fsprogs is not compatible with 
cyrus-imapd?

> But in thinking about what your saying maybe the state of PREFER.${KRB5_TYPE}
> and whether krb5 is being used or not should be considered.
> I.e. if krb5 is being used consider only PREFER.${KRB5_TYPE}, otherwise
> use PREFER.com_err.

PREFER.com_err should not be used now.

I don't know why it is fine for you, but for me (mail/cyrus-imapd24 on 
NetBSD-5.1

make: "../../mk/../../mk/bsd.pkg.mk" line 534: Malformed conditional (defined(USE_BUILTIN.com_err) 
&&  !empty(USE_BUILTIN.com_err:M[yY][eE][sS]) &&  defined(BUILTIN_PKG.com_err) && 
!empty(BUILTIN_PKG.com_err))
make: Fatal errors encountered -- cannot continue


--
OBATA Akio / obache%NetBSD.org@localhost