Re: CVS commit: pkgsrc/devel/xulrunner

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Thu, Jan 05, 2012 at 05:45:04PM +0900, OBATA Akio wrote:
> On Thu, 05 Jan 2012 16:52:05 +0900, Steven Drake <sbd%netbsd.org@localhost> 
> wrote:
> 
> >Module Name: pkgsrc
> >Committed By:        sbd
> >Date:                Thu Jan  5 07:52:05 UTC 2012
> >
> >Modified Files:
> >     pkgsrc/devel/xulrunner: Makefile
> >
> >Log Message:
> >Add yasm>=1.1.0 as a build dependence.
> 
> xulrunner may require yasm for JPEG and VPX support.
> 
> For JPEG, system jpeg is used, so internal jpeg-turbo is not used, then yasm 
> is not required.
> 
> For VPX, internal libvpx will be used and yasm may be required for ASM 
> optimization on x86 arch
> LInux, SunOS and Darwin, from configure script.
> At least, dependency on yasm should be restricted to such platforms.
> Moreover, it is better to add dependency on multimedia/libvpx and
> CONFIGURE_ARGS+=--with-system-libvpx=${BUILDLINK_PREFIX.libvpx}.
> 
> Then I feel such knobs should be in mozilla-common.mk instead.

The change as committed is wrong and must be fixed or reverted. Using
system libvpx is the prefered way.

Joerg