Re: CVS commit: pkgsrc/x11

[Steven Drake <sbd%NetBSD.org@localhost>]

On Wed, 18 Jan 2012, Steven Drake wrote:
> On Thu, 12 Jan 2012, Adam Ciarcinski wrote:
> 
> > Module Name:        pkgsrc
> > Committed By:       adam
> > Date:               Thu Jan 12 22:59:59 UTC 2012
> >
> > [...]
> >
> > Log Message:
> > Changes 4.8.0:
> > Featuring Qt Platform Abstraction, threaded OpenGL support, multithreaded 
> > HTTP
> > and optimized file system access.
> > 
> > [...]
> > 
> >     
> > pkgsrc/x11/qt4-libs/patches/patch-src_3rdparty_webkit_Source_WebCore_platform_DefaultLocalizationStrategy.cpp
> >  \
> 
> This patch causes the build to fail with the following error message:
> 
> cc1plus: warnings being treated as errors
> platform/DefaultLocalizationStrategy.cpp: In function 'WTF::String 
> WebCore::formatLocalizedString(WTF::String, ...)':
> platform/DefaultLocalizationStrategy.cpp:62:64: error: second parameter of 
> 'va_start' not last named argument

The patch has the comment 'Fix C++ error.', so what was the error?

BTW qt4-libs is now the number 1 package causing the most breakage from my
last bulk build.

-- 
Steven