Re: CVS commit: pkgsrc/lang/gcc46

[Steven Drake <sbd%NetBSD.org@localhost>]

On Sat, 7 Apr 2012, David Holland wrote:

> On Sat, Apr 07, 2012 at 09:41:00PM +1200, Steven Drake wrote:
>  > > > Module Name:   pkgsrc
>  > > > Committed By:  sbd
>  > > > Date:          Wed Apr  4 22:20:37 UTC 2012
>  > > > 
>  > > > Modified Files:
>  > > >        pkgsrc/lang/gcc46: options.mk
>  > > > 
>  > > > Log Message:
>  > > > Rename option "gcc-c++" to "gcc-cpp" (with legacy support) as pkglint
>  > > > complains with: "gcc-c++" is not a valid option name.
>  > > > 
>  > > > 
>  > > > To generate a diff of this commit:
>  > > > cvs rdiff -u -r1.4 -r1.5 pkgsrc/lang/gcc46/options.mk
>  > > > 
>  > > > Please note that diffs are not public domain; they are subject to the
>  > > > copyright notices on the relevant files.
>  > > > 
>  > > 
>  > > Was"gcc-c++" actually working as an option?
>  > 
>  > Yes it was.
>  > 
>  > > If so, the problem is with pkglint, not the option name, and it should be
>  > > pkglint that is fixed.
>  > 
>  > I was going by the assumption that pkglint was right and I think whether 
> its
>  > changed or not needs to be decided by the pmc.
> 
> pkglint is frequently wrong these days. If in doubt, ask on tech-pkg.

In this case it was and after a decision by a pmc member I've update pkglint
and reverted the changes.

-- 
Steven