Re: CVS commit: pkgsrc/net/xymon

["S.P.Zeidler" <spz%serpens.de@localhost>]

Hi,

Thus wrote David Holland (dholland-pkgchanges%netbsd.org@localhost):

> On Thu, May 10, 2012 at 06:56:06AM +0000, S.P.Zeidler wrote:
>  > > Not clear. I think the problem is that
>  > > 
>  > > OWN_DIRS_PERMS+=        ${SECCGIDIR} ${XYMONUSER} ${XYMONGROUP} 0700
>  > > 
>  > > should not be OWN_DIRS but something else, as SECCGIDIR is under
>  > > PREFIX and (IIRC) OWN_DIRS is meant for stuff elsewhere, like under
>  > > VARBASE.
>  > 
>  > The docs say:
>  > [...]
>  > 
>  > $PKG_SYSCONFDIR usually is $PREFIX/etc
>  > => directories under PREFIX are not magic.
> 
> The problem really does appear to be that it's installing files in an
> OWN_DIRS dir, though.

By no means. That's what *_DIRS exist for.

> (It usually doesn't in destdir mode.)

I'm not sure how you get to that conclusion.

In my test, when I build the package with PKG_OPTIONS.xymon+=snmp, all is
fine.

If the snmp option is not present, it complains about
--- snip ---
pkg_create: can't stat 
`/home/spz/cvs/pkgsrc/net/xymon/work/.destdir/usr/pkg/libexec/xymon/xymon-snmpcollect'
=> Checking file-check results for xymon-4.3.7
ERROR: ************************************************************
ERROR: The following files are in both the PLIST and CHECK_FILES_SKIP:
ERROR: 
/home/spz/cvs/pkgsrc/net/xymon/work/.destdir/usr/pkg/libexec/xymon/xymon-snmpcollect
--- snip ---

We get the file installed (or not) into:
/home/spz/cvs/pkgsrc/net/xymon/work/.destdir/usr/pkg/libexec/xymon/xymon-snmpcollect

that's
DESTDIR=/home/spz/cvs/pkgsrc/net/xymon/work/.destdir
XYMONTOPDIR=$PREFIX/libexec/xymon

XYMONTOPDIR gets created via MAKE_DIRS

SECCGIDIR=${XYMONTOPDIR}/cgi-secure

Given the two possible explanations:

a) the creation of SECCGIDIR via OWN_DIRS_PERMS fouls up the installation
   of exactly one file (always the same file) into a different path
   (and creating SECCGIDIR in that manner did not foul up the package
   creation before the latest update)
b) a file gets installed depending on whether the snmp option for the
   package is set or not. The file is called xymon-snmpcollect. The PLIST
   does not allow for a file being optionally installed, yet.

I think I want to pick explanation b and solve for it.
There, now it builds for snmp option not set, too. All will be well :)

regards,
        spz
-- 
spz%serpens.de@localhost (S.P.Zeidler)