Re: CVS commit: pkgsrc/sysutils/pfstat

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Sun, May 27, 2012 at 11:48:42PM +0200, John Marino wrote:
 > >  >  It is going into the subdir.  The hack only does the final linking;
 > >  >  the subdir's makefile created the object files.
 > >
 > >Ok, that really makes no sense.
 > >
 > >...nor does this, which I'm now(?) seeing in my test environment:
 > >
 > >install ===>  pfstatd
 > >/usr/bin/install   -c -s   -o pbuild -g pkgbulk -m 755
 > >/home/pkgbulk/c/obj/sysutils/pfstat/work/pfstat-2.5/pfstatd/../pfstatd
 > >/home/pkgbulk/c/obj/sysutils/pfstat/work/.destdir/home/pkgbulk/b/pkg/bin/pfstatd
 > >install: 
 > >/home/pkgbulk/c/obj/sysutils/pfstat/work/pfstat-2.5/pfstatd/../pfstatd: not 
 > >a regular file
 > >*** Error code 1
 > 
 > for the record, that's the same error that the hacks.mk fixed on
 > DragonFly.

Huh. Ok...

 > I assumed for whatever reason NetBSD wasn't seeing it
 > since I didn't see it on any bulk build reports.

I only saw it in my test environment; it probably has to do with
bootstrapping vs. not bootstrapping.

There are a lot of differences between bootstrap-mk-files and the
native NetBSD ones. Or it may just be a difference in make itself that
hasn't been imported into pkgsrc yet. But I suspect not; more likely
there's something about how the ${PROG} target is written.

Basically the underlying problem is that .PATH can't really be
expected to work as desired if the names that it applies to aren't
unique. It was latching onto ../pfstatd/ as the path for ${PROG} and
therefore both not building it (since it already existed and wasn't
out of date with respect to the .o files just created) and also trying
to install it.

-- 
David A. Holland
dholland%netbsd.org@localhost