Re: CVS commit: pkgsrc/sysutils

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Jun 05, 2012 at 09:30:19AM +0000, Jean-Yves Migeon wrote:
> Module Name:  pkgsrc
> Committed By: jym
> Date:         Tue Jun  5 09:30:19 UTC 2012
> 
> Modified Files:
>       pkgsrc/sysutils/munin-node: Makefile
>       pkgsrc/sysutils/munin-server: Makefile
> 
> Log Message:
> Kill USERGROUP_PHASE=pre-install as this hardcodes the UID/GID in the
> +INSTALL script. This causes problems when you build the package on one
> machine but install it on another not necessarily with the same
> accounts configured.

Have you verified that it actually installs correctly if the user/group
does not exist already? That's why it was originally added.

Whether or not the UID/GID hard-coding should be done in this case is a
separate question. I'm strongly inclined to say no, but just dropping it
like in this commit is certainly wrong.

Joerg