Re: CVS commit: pkgsrc/lang/polyml

["Filip Hajny" <filip%joyent.com@localhost>]

On 15. 6. 2012, at 12:51, Steven Drake wrote:

> On Fri, 15 Jun 2012, Aleksej Saushev wrote:
> 
>> Steven Drake <sbd%NetBSD.org@localhost> writes:
>> 
>>> On Fri, 15 Jun 2012, Aleksej Saushev wrote:
>>> 
>>>> "Steven Drake" <sbd%netbsd.org@localhost> writes:
>>>> 
>>>>> Module Name:      pkgsrc
>>>>> Committed By:     sbd
>>>>> Date:             Thu Jun 14 22:23:36 UTC 2012
>>>>> 
>>>>> Modified Files:
>>>>>   pkgsrc/lang/polyml: Makefile
>>>>> 
>>>>> Log Message:
>>>>> Add missing devel/gmp buildlink.
>>>> 
>>>> Sorry? How is it missing?
>>>> 
>>>> No binary from the package links against libgmp.
>>> 
>>> # ldd /usr/pkg/lib/libpolyml.so
>>>        linux-vdso.so.1 =>  (0x00007fff918d8000)
>>>        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fc3b8797000)
>>>        libgmp.so.10 => /usr/pkg/lib/libgmp.so.10 (0x00007fc3b851f000)
>>>     [ ... ]
>> 
>> This doesn't demonstrate that the package needs it directly.
>> Can you check if you don't need it through some dependency?
> 
> True but seeing:
> 
> checking for __gmpn_tdiv_qr in -lgmp... yes
> checking gmp.h usability... yes
> checking gmp.h presence... yes
> checking for gmp.h... yes
> 
> in the configure output does, that and the '--with-gmp' configure option.
> 

Just because your system does have gmp installed, and lang/polyml will be happy 
to auto-find and use it, you shouldn't introduce a dependency that's unneeded 
for (most) other platforms. Either disable building with gmp, or - if your 
platform truly needs it - add its buildlink3 for your platform only.

-F